[
https://issues.apache.org/jira/browse/MESOS-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490105#comment-16490105
]
Qian Zhang commented on MESOS-8829:
-----------------------------------
commit a8eac5bb33fd23e4fc114e8941cde0a666a17e84
Author: Andrei Budnik
Date: Fri May 25 09:08:18 2018 +0800
Removed extra `containerizer->wait()` calls in tests.
Previously, `wait()` and `destroy()` containerizer methods returned
different types, so it was necessarry to call `wait()` before calling
`destroy()` to get the process's exit status. Now, as both methods
return `ContainerTermination`, we can get rid of redundant `wait()`
calls.
Review: https://reviews.apache.org/r/67128/
> Get rid of extra `containerizer->wait()` calls in tests.
> --------------------------------------------------------
>
> Key: MESOS-8829
> URL: https://issues.apache.org/jira/browse/MESOS-8829
> Project: Mesos
> Issue Type: Improvement
> Reporter: Andrei Budnik
> Assignee: Andrei Budnik
> Priority: Major
> Fix For: 1.7.0
>
>
> Since both `wait()` and `destroy()` return the same result, we can get rid of
> extra `containerizer->wait()` call in tests. E.g
> [here|https://github.com/apache/mesos/blob/c662048ae365630e3249b51102c9f7f962cc24d3/src/tests/slave_recovery_tests.cpp#L2292-L2300]
> and
> [there|https://github.com/apache/mesos/blob/c662048ae365630e3249b51102c9f7f962cc24d3/src/tests/cluster.cpp#L654-L668]
> as well as in some other places.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
