[
https://issues.apache.org/jira/browse/MESOS-8923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490614#comment-16490614
]
Alexander Rukletsov commented on MESOS-8923:
--------------------------------------------
{noformat}
commit 415451ee819d384af25f23885a26d15e83b1b785
Author: Alexander Rukletsov <[email protected]>
AuthorDate: Fri May 18 15:25:22 2018 +0200
Commit: Alexander Rukletsov <[email protected]>
CommitDate: Fri May 25 14:02:47 2018 +0200
Ensured `SlaveRegisteredMessage`s trigger appropriate expectations.
An agent may retry `SlaveRegisteredMessage` if it does not receive
the registration confirmation on time. In this case the confirmation
may be sent twice. In tests with multiple registering agents, this
may result that an expectation set for one agent is satisfied by
a retried confirmation for another agent.
This patch unifies the way how this case is handled. An expectation
is augmented with a matcher for with the agent pid for which the
expectation is set.
Review: https://reviews.apache.org/r/67217
{noformat}
> Naked expectations can lead to flaky tests.
> -------------------------------------------
>
> Key: MESOS-8923
> URL: https://issues.apache.org/jira/browse/MESOS-8923
> Project: Mesos
> Issue Type: Task
> Components: test
> Reporter: Alexander Rukletsov
> Priority: Major
>
> There are several cases when too general expectations can be triggered by
> related but not targeted events. Examples:
> 1. Resent task status update before ack due to clock manipulation
> 2. Advancing clock with {{registration_backoff_factor}} to ensure successful
> registration might lead to a case where the first agent resends registration
> request and hence satisfies the expectation for the second agent.
> A possible solution would be extensive use of matchers and extra primitives
> wrapping them. For example, a possible approach to 1. is
> https://reviews.apache.org/r/63577/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
