[
https://issues.apache.org/jira/browse/MESOS-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493311#comment-16493311
]
Alexander Rukletsov commented on MESOS-8954:
--------------------------------------------
{noformat}
commit 5984e68e19018890ac6a3d27133aa84b5f859b00
Author: Armand Grillet [email protected]
AuthorDate: Fri May 25 14:00:48 2018 +0200
Commit: Alexander Rukletsov [email protected]
CommitDate: Fri May 25 14:02:26 2018 +0200
Fixed python3/post-reviews.py type error.
The main challenge when switching from Python 2 to Python 3 is
to handle the strings, as many of them are now byte strings. I
have checked the other uses of `sys.stdout.buffer.write` while
working on this commit to check that it was the last issue of
that type in python3/post-reviews.py.
Review: https://reviews.apache.org/r/67321/
{noformat}
{noformat}
commit c8ce487a2f55fcc6daf0968a7b53f12b3bcdc0e8
Author: Armand Grillet [email protected]
AuthorDate: Tue May 29 11:43:00 2018 +0200
Commit: Alexander Rukletsov [email protected]
CommitDate: Tue May 29 11:43:29 2018 +0200
Fixed python3/mesos-style.py type error.
The main challenge when switching from Python 2 to Python 3 is
to handle the strings, as many of them are now byte strings. I
have checked the other uses of `sys.stderr.write` while working
on this commit to check that it was the last issue of that type
in python3/mesos-style.py.
Review: https://reviews.apache.org/r/67340/
{noformat}
> python3/post-reviews.py errors due to TypeError.
> ------------------------------------------------
>
> Key: MESOS-8954
> URL: https://issues.apache.org/jira/browse/MESOS-8954
> Project: Mesos
> Issue Type: Bug
> Reporter: Armand Grillet
> Assignee: Armand Grillet
> Priority: Major
> Labels: mesosphere, python
> Fix For: 1.7.0
>
>
> {code:java}
> $ ./support/python3/post-reviews.py
> Running 'rbt post' across all of ...
> 7a662ee75d706d637f9cc2bcbdd0567c32ccef56 - (HEAD -> alexr/subscribers-health,
> private/ci/alexr/default) Sent task (health) check updates over the operator
> streaming API. (2 minutes ago)
> Creating diff of:
> 7a662ee75d706d637f9cc2bcbdd0567c32ccef56 - (HEAD -> alexr/subscribers-health,
> private/ci/alexr/default) Sent task (health) check updates over the operator
> streaming API.
> Press enter to continue or 'Ctrl-C' to skip.
> Traceback (most recent call last):
> File "./support/python3/post-reviews.py", line 432, in <module>
> main()
> File "./support/python3/post-reviews.py", line 365, in main
> sys.stdout.buffer.write(output)
> TypeError: a bytes-like object is required, not 'str'{code}
> The review still get posted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
