[
https://issues.apache.org/jira/browse/MESOS-8945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495209#comment-16495209
]
Benjamin Bannier edited comment on MESOS-8945 at 5/30/18 2:10 PM:
------------------------------------------------------------------
[~jieyu] [~bmahler] Small question on the target versions: The patch above
applies cleanly on {{1.5.x}} and {{1.6.x}}, but breaks {{1.4.x}} since we might
invoke {{Resources::isEmpty}} on potentially invalid resources (e.g., a
{{Resource}} which has a {{role}}). It looks we only made the upgrade to
post-refinement format automatic with {{1.5.x}} forward.
I am tempted to not fix this on {{1.4.x}} as the code patch hitting above
assertion failure is not present in {{1.4.x}}.
What do you think?
was (Author: bbannier):
[~jieyu] [~bmahler] Small question on fix version: The patch above applies
cleanly on {{1.5.x}} and {{1.6.x}}, but breaks {{1.4.x}} since we might invoke
{{Resources::isEmpty}} on potentially invalid resources (e.g., a {{Resource}}
which has a {{role}}). It looks we only made the upgrade to post-refinement
format automatic with {{1.5.x}} forward.
I am tempted to not fix this on {{1.4.x}} as the code patch hitting above
assertion failure is not present in {{1.4.x}}.
What do you think?
> Master check failure due to CHECK_SOME(providerId).
> ---------------------------------------------------
>
> Key: MESOS-8945
> URL: https://issues.apache.org/jira/browse/MESOS-8945
> Project: Mesos
> Issue Type: Bug
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Jie Yu
> Assignee: Benjamin Bannier
> Priority: Critical
>
> {noformat}
> 2018-05-15 23:19:23: I0515 23:19:23.764744 7080 master.cpp:4637] Applying
> RESERVE operation for resources
> [{"allocation_info":{"role":"test__integration__hello-world-role"},"name":"cpus","reservations":[{"labels":{"labels":[{"key":"resource_id","value":"bc19583a-6795-46e4-bac0-15804bf46c44"}]},"principal":"\/test\/integration\/hello-world-principal","role":"test__integration__hello-world-role","type":"DYNAMIC"}],"scalar":{"value":5.55111512312578e-17},"type":"SCALAR"}]
> from framework 101d3dc6-e05d-4d28-acb9-9ee24886b608-0034
> (/test/integration/hello-world) to agent
> 101d3dc6-e05d-4d28-acb9-9ee24886b608-S6 at slave(1)@10.0.3.242:5051
> (10.0.3.242)
> 2018-05-15 23:19:23: F0515 23:19:23.766151 7080 master.cpp:12065]
> CHECK_SOME(providerId): Could not determine resource provider
> 2018-05-15 23:19:23: *** Check failure stack trace: ***
> 2018-05-15 23:19:23: @ 0x7f45db7a305d google::LogMessage::Fail()
> 2018-05-15 23:19:23: @ 0x7f45db7a4e8d google::LogMessage::SendToLog()
> 2018-05-15 23:19:23: @ 0x7f45db7a2c4c google::LogMessage::Flush()
> 2018-05-15 23:19:23: @ 0x7f45db7a5789
> google::LogMessageFatal::~LogMessageFatal()
> 2018-05-15 23:19:23: @ 0x7f45da603fe9 _CheckFatal::~_CheckFatal()
> 2018-05-15 23:19:23: @ 0x7f45da83755d
> mesos::internal::master::Slave::apply()
> 2018-05-15 23:19:23: @ 0x7f45da84d4db
> mesos::internal::master::Master::_apply()
> 2018-05-15 23:19:23: @ 0x7f45da855433
> mesos::internal::master::Master::_accept()
> 2018-05-15 23:19:23: @ 0x7f45db6fe831 process::ProcessBase::consume()
> 2018-05-15 23:19:23: @ 0x7f45db70d73c
> process::ProcessManager::resume()
> 2018-05-15 23:19:23: @ 0x7f45db712c36
> _ZNSt6thread5_ImplISt12_Bind_simpleIFZN7process14ProcessManager12init_threadsEvEUlvE_vEEE6_M_runEv
> 2018-05-15 23:19:23: @ 0x7f45d8987d73 (unknown)
> 2018-05-15 23:19:23: @ 0x7f45d818452c (unknown)
> 2018-05-15 23:19:23: @ 0x7f45d7ec21dd (unknown)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
