[
https://issues.apache.org/jira/browse/MESOS-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519659#comment-16519659
]
Meng Zhu edited comment on MESOS-8936 at 6/21/18 6:15 PM:
----------------------------------------------------------
{noformat}
commit 0912ff8aa7f283994fbdbaa9f6a95a114310af5e
Author: Benjamin Mahler
Date: Sat Jun 2 21:23:08 2018 -0400
Introduced a weighted shuffle algorithm implementation.
This will be used by the random sorter in order to support weights.
Review: https://reviews.apache.org/r/67369/
{noformat}
{noformat}
commit c9911766a57d0abd11c47276a10e21d4cbee7124
Author: Benjamin Mahler
Date: Sat Jun 2 21:25:58 2018 -0400
Added a test for weighted shuffling.
Review: https://reviews.apache.org/r/67370/
{noformat}
{noformat}
commit 5cc2558a889b9e30781460f9bdfd947900fbab47
Author: Benjamin Mahler
Date: Sat Jun 2 21:27:10 2018 -0400
Introduced a random sorter as an alternative to the DRF sorter.
This sorter returns a weighted random shuffling of its clients
upon each `sort()` request.
This implementation is a copy of the `DRFSorter` with share
calculation logic (including the `dirty` bit) removed and an
adjusted `sort()` implementation. Work needs to be done to
reduce the amount of duplicated logic needed across sorter
implementations, but it is left unaddressed here.
Review: https://reviews.apache.org/r/67371/
{noformat}
{noformat}
commit 4356fea756c466a4f9824b0b647879fada3e4dc5
Author: Benjamin Mahler
Date: Mon Jun 4 15:04:05 2018 -0400
Updated sorter tests to run against multiple sorters where possible.
Several of the sorter tests, including the benchmarks, were agnostic
to the sorter implementation. These have been updated to run for both
`DRFSorter` and `RandomSorter`. The remainder have been updated to
be called DRFSorter tests.
Review: https://reviews.apache.org/r/67372/
{noformat}
{noformat}
commit b8c635d7205305ce09fd158a035f94c8baef93c7
Author: Benjamin Mahler
Date: Mon Jun 4 15:17:19 2018 -0400
Added typedefs for using the allocator with random sorters.
Review: https://reviews.apache.org/r/67373/
{noformat}
{noformat}
commit cacc1dbfc4ee5b72f08c32e7ccc39221091715a8
Author: Benjamin Mahler
Date: Mon Jun 4 15:17:39 2018 -0400
Updated flags to support choosing the random sorter.
This deprecates `--user_sorter` in favor of `--role_sorter`.
This patch also modifies the `--allocator` default to exclude "DRF"
from the value, while still ensuring the previous default works.
For now, both sorter flags must be set to `drf` or `random`.
Review: https://reviews.apache.org/r/67374/
{noformat}
was (Author: mzhu):
{{commit 0912ff8aa7f283994fbdbaa9f6a95a114310af5e
Author: Benjamin Mahler
Date: Sat Jun 2 21:23:08 2018 -0400
Introduced a weighted shuffle algorithm implementation.
This will be used by the random sorter in order to support weights.
Review: https://reviews.apache.org/r/67369/}}
{{commit c9911766a57d0abd11c47276a10e21d4cbee7124
Author: Benjamin Mahler
Date: Sat Jun 2 21:25:58 2018 -0400
Added a test for weighted shuffling.
Review: https://reviews.apache.org/r/67370/}}
{{commit 5cc2558a889b9e30781460f9bdfd947900fbab47
Author: Benjamin Mahler
Date: Sat Jun 2 21:27:10 2018 -0400
Introduced a random sorter as an alternative to the DRF sorter.
This sorter returns a weighted random shuffling of its clients
upon each `sort()` request.
This implementation is a copy of the `DRFSorter` with share
calculation logic (including the `dirty` bit) removed and an
adjusted `sort()` implementation. Work needs to be done to
reduce the amount of duplicated logic needed across sorter
implementations, but it is left unaddressed here.
Review: https://reviews.apache.org/r/67371/}}
{{commit 4356fea756c466a4f9824b0b647879fada3e4dc5
Author: Benjamin Mahler
Date: Mon Jun 4 15:04:05 2018 -0400
Updated sorter tests to run against multiple sorters where possible.
Several of the sorter tests, including the benchmarks, were agnostic
to the sorter implementation. These have been updated to run for both
`DRFSorter` and `RandomSorter`. The remainder have been updated to
be called DRFSorter tests.
Review: https://reviews.apache.org/r/67372/}}
{{commit b8c635d7205305ce09fd158a035f94c8baef93c7
Author: Benjamin Mahler
Date: Mon Jun 4 15:17:19 2018 -0400
Added typedefs for using the allocator with random sorters.
Review: https://reviews.apache.org/r/67373/}}
{{commit cacc1dbfc4ee5b72f08c32e7ccc39221091715a8
Author: Benjamin Mahler
Date: Mon Jun 4 15:17:39 2018 -0400
Updated flags to support choosing the random sorter.
This deprecates `--user_sorter` in favor of `--role_sorter`.
This patch also modifies the `--allocator` default to exclude "DRF"
from the value, while still ensuring the previous default works.
For now, both sorter flags must be set to `drf` or `random`.
Review: https://reviews.apache.org/r/67374/}}
> Implement a Random Sorter for offer allocations
> -----------------------------------------------
>
> Key: MESOS-8936
> URL: https://issues.apache.org/jira/browse/MESOS-8936
> Project: Mesos
> Issue Type: Task
> Components: allocation
> Reporter: Vinod Kone
> Assignee: Benjamin Mahler
> Priority: Major
>
> The only sorter that Mesos supports today is the DRF sorter. But, there are
> cases when DRF sorting causes offer fragmentation when dealing with
> non-revocable resources and multiple frameworks. One of the options to
> improve this situation is to introduce a new random sorter instead of DRF
> sorter.
> See
> [https://docs.google.com/document/d/1uvTmBo_21Ul9U_mijgWyh7hE0E_yZXrFr43JIB9OCl8/edit#heading=h.nfye94rqpotp]
> for additional details.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
