[
https://issues.apache.org/jira/browse/MESOS-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526242#comment-16526242
]
Till Toenshoff commented on MESOS-8990:
---------------------------------------
So the fix has landed in googletest but no release of googletest contains it so
far, correct? For unblocking you here, we would need to add this to our
3rdparty patches. Would you be able to contribute such patch?
[~andschwa] what do you think, is it reasonable to add this as an additional
3rdparty patch?
> Could you help pick up https://github.com/google/googletest/pull/1620 fix in
> Google Test
> -----------------------------------------------------------------------------------------
>
> Key: MESOS-8990
> URL: https://issues.apache.org/jira/browse/MESOS-8990
> Project: Mesos
> Issue Type: Task
> Components: build
> Reporter: PhoebeHui
> Priority: Blocker
>
> Hi,
> Build Mesos with msvc on windows currently blocked by the following issue,
> this issue has fixed on Goolgetest, could you help pick up it in Mesos?
> The next release msvc toolset will have this behavior.
> See background in
> [{color:#0066cc}https://github.com/google/googletest/issues/1616{color}], and
> the fix
> [{color:#0066cc}https://github.com/google/googletest/pull/1620{color}].
> The failures like:
>
> d:\mesos\build_x64\3rdparty\googletest-1.8.0\src\googletest-1.8.0\googletest\include\gtest\gtest-printers.h(249,1):
> error C2593: 'operator <<' is ambiguous
> [D:\Mesos\build_x64\src\tests\mesos-tests.vcxproj]
> d:\mesos\build_x64\3rdparty\googletest-1.8.0\src\googletest-1.8.0\googletest\include\gtest\gtest-printers.h(249,1):
> error C2593: *os << value;
> [D:\Mesos\build_x64\src\tests\mesos-tests.vcxproj]
> d:\mesos\build_x64\3rdparty\googletest-1.8.0\src\googletest-1.8.0\googletest\include\gtest\gtest-printers.h(249,1):
> error C2593: ^ (compiling source file
> D:\Mesos\src\src\tests\command_executor_tests.cpp)
> [D:\Mesos\build_x64\src\tests\mesos-tests.vcxproj]
>
> Thank you in advance!
> Phoebe
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
