[
https://issues.apache.org/jira/browse/MESOS-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537771#comment-16537771
]
Till Toenshoff edited comment on MESOS-7397 at 7/9/18 11:19 PM:
----------------------------------------------------------------
No, that is not what I meant to explain --- use any review that has not yet
landed and is not part of a chain and try {{support/apply-reviews.sh -c -r
WHATEVER_RR}}
Before december last year (roughly) that worked fine, so this is a regression.
was (Author: tillt):
No, that is not what I meant to explain --- use any review that has not yet
landed and try my walkthrough.
> apply-reviews.py silently fails when using chain mode.
> ------------------------------------------------------
>
> Key: MESOS-7397
> URL: https://issues.apache.org/jira/browse/MESOS-7397
> Project: Mesos
> Issue Type: Bug
> Reporter: Till Toenshoff
> Priority: Minor
>
> When using {{apply-reviews.py}} in chain mode {{--chain}} it suppresses error
> messages when patches do not apply.
> Example on {{1.0.x}}:
> {noformat}
> $ ./support/apply-reviews.py -c -r 57764
> $
> {noformat}
> If used without chain mode, the error message is properly displayed:
> {noformat}
> $ ./support/apply-reviews.py -r 57764
> 2017-04-18 11:45:58 URL:https://reviews.apache.org/r/57764/diff/raw/
> [1067/1067] -> "57764.patch" [1]
> error: patch failed: src/launcher/posix/executor.cpp:116
> error: src/launcher/posix/executor.cpp: patch does not apply
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
