Benjamin Bannier commented on MESOS-8770:

commit 14c68199cb0a35c8f5dc77472ba483a73ae88653
Author: Armand Grillet <agril...@mesosphere.io>
Date:   Wed Jul 11 12:22:00 2018 +0200

    Updated Python virtual environment dependencies.
    Fixes the error message when running support/build-virtualenv:
    `npm WARN ajv-keywords@3.2.0 requires a peer of ajv@^6.0.0 but none
    is installed. You must install peer dependencies yourself.`.
    Updates the PyInstaller dependency due to issues with PyInstaller
    3.1.1 and Python 3.6.
    Review: https://reviews.apache.org/r/67856/

commit 1cc7054d1ae9b6180013353ddb7d5427f01c7cb2
Author: Armand Grillet <agril...@mesosphere.io>
Date:   Wed Jul 11 12:21:54 2018 +0200

    Added virtualenv requirements watcher to Python 3 mesos-style.py.
    The Python and JavaScript linters run by mesos-style.py, called
    by our Git hooks, require a virtual environment. This virtual
    environment needs to be rebuilt by running `build-virtualenv`
    each time the pip dependencies of our Python codebase are
    The check `should_build_virtualenv` had not been added to the Python 3
    `mesos-style.py` for an unknown reason and this is now fixed.
    We pass the Python interpreter used to run `mesos-style.py` when running
    `build-virtualenv` in case Python 3 is used to run `mesos-style.py`
    but Python 2 is still the default `python`.
    Review: https://reviews.apache.org/r/67855/

> Use Python3 for Mesos support scripts
> -------------------------------------
>                 Key: MESOS-8770
>                 URL: https://issues.apache.org/jira/browse/MESOS-8770
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Benjamin Bannier
>            Assignee: Armand Grillet
>            Priority: Major
> Our Python scripts under {{support/}} currently implicitly assume that 
> developers have a python2 environment as their primary Python installation.
> We should consider updating these scripts so that they can be used with a 
> python3 installation as well. There exist [some 
> resources|http://python-future.org/overview.html#automatic-conversion-to-py2-3-compatible-code]
>  on the web documenting best practices and tools for automatic rewrites which 
> should get us a long way.

This message was sent by Atlassian JIRA

Reply via email to