[
https://issues.apache.org/jira/browse/MESOS-9097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554757#comment-16554757
]
Andrew Schwartzmeyer commented on MESOS-9097:
---------------------------------------------
commit cf51b2360
Author: Andrew Schwartzmeyer
Date: Wed Jul 18 15:48:43 2018 -0700
Fixed `test-linkee` logic in `ProcessRemoteLinkTest::SetUp()`.
Several problems existed on Windows here:
* The `BUILD_DIR` path has forward slashes (probably fine, but wrong).
* The executable must be named correctly, `.exe` and all.
* We should assert that `test-linkee` exists.
* The shell should not be used, otherwise `'(62)'` will resolve to an
unknown UPID inside `test-linkee` because of the single quotes.
Review: https://reviews.apache.org/r/67977
> `libwinio_loop` must be initialized before `Socket` constructor is called
> -------------------------------------------------------------------------
>
> Key: MESOS-9097
> URL: https://issues.apache.org/jira/browse/MESOS-9097
> Project: Mesos
> Issue Type: Bug
> Affects Versions: 1.7.0
> Environment: Windows with \{{-DENABLE_LIBWINIO=ON}}
> Reporter: Andrew Schwartzmeyer
> Assignee: Akash Gupta
> Priority: Major
> Labels: libprocess, windows
>
> When building with {{-DENABLE_LIBWINIO}}, initializing the Windows event loop
> (specifically the pointer {{process::libwinio_loop}}) becomes a prerequisite
> to creating a {{Socket}}. If it has not been initialized, then when the
> {{Socket}} constructor calls {{prepare_async()}}, a null pointer is
> dereferenced, leading to a hang on Windows.
> This was discovered in the simple program {{test-linkee}} where a {{Socket}}
> is created and used, but the entire libprocess event loop is unused. This is
> temporarily fixed by calling {{process::initialize()}} early in
> {{test-linkee}}, but this should probably not be required. Instead,
> {{prepare_async()}} (or any use of {{libwinio_loop}} should probably
> auto-initialize the event loop if required.
> For now, I am adding fatal checks before a null pointer dereference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
