[
https://issues.apache.org/jira/browse/MESOS-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572216#comment-16572216
]
Meng Zhu commented on MESOS-9110:
---------------------------------
`Resource_` is used only internally. I do not see any use case for `Resources
operator+(const Resource_& that)`, let alone ref-qualified version. I think we
can remove all existing `operator+(Resource_)` overloads and close this ticket:
https://reviews.apache.org/r/68262/
> Add move support to the Resources / Resource_ wrappers.
> -------------------------------------------------------
>
> Key: MESOS-9110
> URL: https://issues.apache.org/jira/browse/MESOS-9110
> Project: Mesos
> Issue Type: Improvement
> Reporter: Benjamin Mahler
> Assignee: Meng Zhu
> Priority: Major
> Labels: mesosphere, performance
>
> Currently, the Resources / Resource_ wrappers do not have move support. Since
> copying resources are rather expensive (especially when there's large ports
> ranges or metadata like reservations / labels), we should add move support to
> reduce copying automatically where possible:
> * Constructors for both Resources and Resource_
> * +, +=, addition operations: with addition we sometimes need to add the
> resource to the vector in which case we can move if taking an rvalue
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
