[
https://issues.apache.org/jira/browse/MESOS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594023#comment-16594023
]
ASF GitHub Bot commented on MESOS-3932:
---------------------------------------
andschwa closed pull request #104: MESOS-3932 Suppressed boost auto_ptr compile
warnings.
URL: https://github.com/apache/mesos/pull/104
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index e0c538d9e6..cfb05475e6 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -388,7 +388,7 @@ add_definitions(-DUSE_STATIC_LIB -DBUILD_DATE=0
-DBUILD_TIME=0 -DBUILD_USER="fra
# INCLUDE DIRECTIVES FOR MESOS LIBRARY (generates, e.g., -I/path/to/thing
# on Linux).
#########################################################################
-include_directories(${AGENT_INCLUDE_DIRS})
+include_directories(SYSTEM ${AGENT_INCLUDE_DIRS})
# LINKING LIBRARIES BY DIRECTORY (might generate, e.g., -L/path/to/thing on
# Linux).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Silence Boost compiler warnings with CMake
> ------------------------------------------
>
> Key: MESOS-3932
> URL: https://issues.apache.org/jira/browse/MESOS-3932
> Project: Mesos
> Issue Type: Bug
> Reporter: Neil Conway
> Assignee: Alex Clemmer
> Priority: Minor
> Labels: cmake, mesosphere, microsoft
> Fix For: 1.2.0
>
>
> Per MESOS-3799, we should silence at least two kinds of compiler warning
> fixes when including the Boost headers:
> * Add -Wno-unused-local-typedefs to CXXFLAGS
> * Use -isystem when including Boost to avoid deprecation warnings for use of
> auto_ptr
> I believe we technically need both, IIRC because some other depedencies pull
> in Boost using their own -I flag.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
