Till Toenshoff created MESOS-9203:
-------------------------------------

             Summary: apply-reviews.py fails to apply a review when out of 
mesos-root.
                 Key: MESOS-9203
                 URL: https://issues.apache.org/jira/browse/MESOS-9203
             Project: Mesos
          Issue Type: Bug
            Reporter: Till Toenshoff


{{apply-reviews.py}} since it had been altered a lot over the last year, now 
fails to apply reviews when the user is not within the mesos-root directory.
There is no helpful error message but instead I see this when applying a patch 
that is still in review:
{noformat}
$ ../support/apply-reviews.py -r 68604
Congratulations! You have Python 3 installed correctly.
Please start using the scripts in `support/python3`.
Please also set the environment variable `MESOS_SUPPORT_PYTHON` to `3`
so that the Git hooks use the Python 3 scripts.
2018-09-03 00:29:18 URL:https://reviews.apache.org/r/68604/diff/raw/ [937/937] 
-> "68604.patch" [1]
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
{noformat}

I would expect either that it just works(™)  or would result in an error 
message, telling me where I went wrong - e.g.:
{noformat}
Could not apply any patches. Please invoke 'supply-reviews.py' from within the 
mesos root directory. 
{noformat}





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to