[ https://issues.apache.org/jira/browse/MESOS-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619417#comment-16619417 ]
Alexander Rukletsov commented on MESOS-8545: -------------------------------------------- *{{master}} aka {{1.8-dev}}*: {noformat} commit 5b95bb0f21852058d22703385f2c8e139881bf1a Author: Andrei Budnik <abud...@mesosphere.com> AuthorDate: Tue Sep 18 19:10:14 2018 +0200 Commit: Alexander Rukletsov <al...@apache.org> CommitDate: Tue Sep 18 19:10:14 2018 +0200 Fixed HTTP errors caused by dropped HTTP responses by IOSwitchboard. Previously, IOSwitchboard process could terminate before all HTTP responses had been sent to the agent. In the case of `ATTACH_CONTAINER_INPUT` call, we could drop a final HTTP `200 OK` response, so the agent got broken HTTP connection for the call. This patch introduces an acknowledgment for the received response for the `ATTACH_CONTAINER_INPUT` call. This acknowledgment is a new type of control messages for the `ATTACH_CONTAINER_INPUT` call. When IOSwitchboard receives an acknowledgment, and io redirects are finished, it terminates itself. That guarantees that the agent always receives a response for the `ATTACH_CONTAINER_INPUT` call. Review: https://reviews.apache.org/r/65168/ {noformat} {noformat} commit 5b95bb0f21852058d22703385f2c8e139881bf1a Author: Andrei Budnik <abud...@mesosphere.com> AuthorDate: Tue Sep 18 19:10:14 2018 +0200 Commit: Alexander Rukletsov <al...@apache.org> CommitDate: Tue Sep 18 19:10:14 2018 +0200 Fixed HTTP errors caused by dropped HTTP responses by IOSwitchboard. Previously, IOSwitchboard process could terminate before all HTTP responses had been sent to the agent. In the case of `ATTACH_CONTAINER_INPUT` call, we could drop a final HTTP `200 OK` response, so the agent got broken HTTP connection for the call. This patch introduces an acknowledgment for the received response for the `ATTACH_CONTAINER_INPUT` call. This acknowledgment is a new type of control messages for the `ATTACH_CONTAINER_INPUT` call. When IOSwitchboard receives an acknowledgment, and io redirects are finished, it terminates itself. That guarantees that the agent always receives a response for the `ATTACH_CONTAINER_INPUT` call. Review: https://reviews.apache.org/r/65168/ {noformat} > AgentAPIStreamingTest.AttachInputToNestedContainerSession is flaky. > ------------------------------------------------------------------- > > Key: MESOS-8545 > URL: https://issues.apache.org/jira/browse/MESOS-8545 > Project: Mesos > Issue Type: Bug > Components: agent > Affects Versions: 1.5.0, 1.6.1, 1.7.0 > Reporter: Andrei Budnik > Assignee: Andrei Budnik > Priority: Major > Labels: Mesosphere, flaky-test > Attachments: > AgentAPIStreamingTest.AttachInputToNestedContainerSession-badrun.txt, > AgentAPIStreamingTest.AttachInputToNestedContainerSession-badrun2.txt > > > {code:java} > I0205 17:11:01.091872 4898 http_proxy.cpp:132] Returning '500 Internal Server > Error' for '/slave(974)/api/v1' (Disconnected) > /home/centos/workspace/mesos/Mesos_CI-build/FLAG/CMake/label/mesos-ec2-centos-7/mesos/src/tests/api_tests.cpp:6596: > Failure > Value of: (response).get().status > Actual: "500 Internal Server Error" > Expected: http::OK().status > Which is: "200 OK" > Body: "Disconnected" > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)