[
https://issues.apache.org/jira/browse/MESOS-9343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673820#comment-16673820
]
Kevin Klues commented on MESOS-9343:
------------------------------------
{noformat}
commit 9441e48338a8c58adc1e88c9fc1804d10f201262
Author: Armand Grillet <[email protected]>
Date: Fri Nov 2 19:39:06 2018 -0400
Simplified newline handling in 'test_exec()' test for new CLI.
The test was previously using '.strip()' to compare the command stdout
and the result we expect. This check was incorrect because it could
happen that the output ended in a bunch of extra whitespace that we
would then strip off unknowningly. By replacing the task command to use
'printf' instead of 'echo' (which artifically inserts an extra newline
in the output), we are able to simplify this assertion and make sure the
output is exactly the same as what we expect.
Review: https://reviews.apache.org/r/69237/
{noformat}
> Add test(s) for `mesos task attach` on task launched with a TTY
> ----------------------------------------------------------------
>
> Key: MESOS-9343
> URL: https://issues.apache.org/jira/browse/MESOS-9343
> Project: Mesos
> Issue Type: Task
> Components: cli
> Reporter: Armand Grillet
> Assignee: Armand Grillet
> Priority: Major
>
> As a source, we could use the tests in
> https://github.com/dcos/dcos-core-cli/blob/b930d2004dceb47090004ab658f35cb608bc70e4/python/lib/dcoscli/tests/integrations/test_task.py
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
