[
https://issues.apache.org/jira/browse/MESOS-9164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679389#comment-16679389
]
Qian Zhang commented on MESOS-9164:
-----------------------------------
commit d9a02acb8c9440c29811e6f66fe2e1146a04aa52
Author: Qian Zhang
Date: Wed Aug 29 10:17:05 2018 +0800
Closed all file descriptors except `whitelist_fds` in posix/subprocess.
Review: https://reviews.apache.org/r/68644
commit df0a616e3555767e308a87c787d5ad5cdd4e66c1
Author: Qian Zhang
Date: Fri Oct 12 22:04:02 2018 +0800
Added a test `SubprocessTest.WhiteListFds`.
Review: https://reviews.apache.org/r/69016
commit bb533b784928bca1553b6ed86d10105de26bb76d
Author: Qian Zhang
Date: Mon Sep 3 15:09:24 2018 +0800
Updated IO switchboard to use subprocess's `whitelist_fds` parameter.
Review: https://reviews.apache.org/r/68645
commit 2455543d7534d2c1491854ff6efff1c75a1c4395
Author: Qian Zhang
Date: Mon Sep 3 15:11:51 2018 +0800
Updated launchers to use subprocess's `whitelist_fds` parameter.
Review: https://reviews.apache.org/r/68646
commit face988a52b0775f0c3e959d1f164212c1eba96c
Author: Qian Zhang
Date: Mon Oct 8 16:06:31 2018 +0800
Removed the child hook `UNSET_CLOEXEC`.
We do not need this child hook since any file descripters need
to unset the close-on-exec flag can be put in the `whitelist_fds`
parameter of the `subprocess` method.
Review: https://reviews.apache.org/r/68995
> Subprocess should unset CLOEXEC on whitelisted file descriptors.
> ----------------------------------------------------------------
>
> Key: MESOS-9164
> URL: https://issues.apache.org/jira/browse/MESOS-9164
> Project: Mesos
> Issue Type: Bug
> Components: libprocess
> Reporter: James Peach
> Assignee: Qian Zhang
> Priority: Major
>
> The libprocess subprocess API accepts a set of whitelisted file descriptors
> that are supposed to be inherited to the child process. On windows, these
> are used, but otherwise the subprocess API just ignores them. We probably
> should make sure that the API clears the {{CLOEXEC}} flag on this descriptors
> so that they are inherited to the child.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
