[
https://issues.apache.org/jira/browse/MESOS-9210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756207#comment-16756207
]
Till Toenshoff commented on MESOS-9210:
---------------------------------------
1.5.x:
{noformat}
commit 5f21540e5f45d05e7b5c4450f5074bc30d254fa1
Author: Till Toenshoff <[email protected]>
Date: Wed Jan 30 13:51:34 2019 +0100
Fixed scheduler library on multiple SUBSCRIBE requests per connection.
The HTTP scheduler API dictates that on a single connection, the
scheduler may only send a single SUBSCRIBE request. Due to recent
authentication related changes, this contract got broken. This patch
restores the contract.
Review: https://reviews.apache.org/r/69839/
(cherry picked from commit a5b9fcafbdf8663707e19c818be8a2da1eff8622){noformat}
1.6.x:
{noformat}
commit d97fa5cd0d3c72d7f89b443603f255d57571b07c
Author: Till Toenshoff <[email protected]>
Date: Wed Jan 30 13:51:34 2019 +0100
Fixed scheduler library on multiple SUBSCRIBE requests per connection.
The HTTP scheduler API dictates that on a single connection, the
scheduler may only send a single SUBSCRIBE request. Due to recent
authentication related changes, this contract got broken. This patch
restores the contract.
Review: https://reviews.apache.org/r/69839/
(cherry picked from commit a5b9fcafbdf8663707e19c818be8a2da1eff8622){noformat}
1.7.x:
{noformat}
commit 4018683beeebadf6722a722ed5d9d8a7e396de8e
Author: Till Toenshoff <[email protected]>
Date: Wed Jan 30 05:37:17 2019 +0100
Fixed scheduler library on multiple SUBSCRIBE requests per connection.
The HTTP scheduler API dictates that on a single connection, the
scheduler may only send a single SUBSCRIBE request. Due to recent
authentication related changes, this contract got broken. This patch
restores the contract and adds a test validating that the library is
enforcing it.
Review: https://reviews.apache.org/r/69839/
(cherry picked from commit a5b9fcafbdf8663707e19c818be8a2da1eff8622){noformat}
> Mesos v1 scheduler library does not properly handle SUBSCRIBE retries
> ---------------------------------------------------------------------
>
> Key: MESOS-9210
> URL: https://issues.apache.org/jira/browse/MESOS-9210
> Project: Mesos
> Issue Type: Bug
> Affects Versions: 1.5.1, 1.6.1, 1.7.0
> Reporter: Vinod Kone
> Assignee: Till Toenshoff
> Priority: Major
> Labels: integration, mesosphere
>
> After the authentication related refactor done as part of
> [https://reviews.apache.org/r/62594/], the state of the scheduler is checked
> in `send`
> ([https://github.com/apache/mesos/blob/master/src/scheduler/scheduler.cpp#L234)]
> but it is changed in `_send`
> ([https://github.com/apache/mesos/blob/master/src/scheduler/scheduler.cpp#L234).]
> As a result, we can have 2 SUBSCRIBE calls in flight at the same time on the
> same connection! This is not good and not spec compliant of a HTTP client
> that is expecting a streaming response.
> We need to fix the library to either drop the retried SUBSCRIBE call if one
> is in progress (as it was before the refactor) or close the old connection
> and start a new connection to send the retried SUBSCRIBE call.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
