[
https://issues.apache.org/jira/browse/MESOS-9582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772319#comment-16772319
]
Benjamin Bannier commented on MESOS-9582:
-----------------------------------------
{noformat}
commit d5ff6c39252875bfa39344639518109e154e599e
Author: Benjamin Bannier <[email protected]>
Date: Tue Feb 19 21:31:31 2019 +0100
Fixed type error in verify-reviews.py.
This patch fixes a type error introduced in `ccd1970d1be` where we
attempted to use a string API on undecoded UTF8 strings. With this
patch the string is properly decoded.
Review: https://reviews.apache.org/r/70012
{noformat}
> Reviewbot jenkins jobs stops validating any reviews as soon as it sees a
> patch which does not apply
> ---------------------------------------------------------------------------------------------------
>
> Key: MESOS-9582
> URL: https://issues.apache.org/jira/browse/MESOS-9582
> Project: Mesos
> Issue Type: Bug
> Components: reviewbot
> Reporter: Benjamin Bannier
> Assignee: Benjamin Bannier
> Priority: Blocker
> Labels: integration, mesosphere
> Fix For: 1.8.0
>
>
> The reviewbot Jenkins setup fetches all Mesos reviews since some time stamp,
> filters that list down to reviews which need to be validated, and then one by
> one validates each of the remaining review requests.
> In doing that it applies patches with {{support/apply-reviews.py}} which is
> invoked by shelling out wth a function {{shell}} in
> {{support/verify-reviews.py}}. If that function sees any error from the shell
> command {{exit(1)}} is called which immediately terminates the Jenkins job.
> As {{support/apply-reviews.py}} can fail if a patch does not apply cleanly
> anymore this means that any review requests which cannot be applied can
> largely disable reviewbot.
> We should avoid calling {{exit}} in low-level functions in
> {{support/verify-reviews.py}} and instead bubble the error up to be handled
> at a larger scope. It looks like the script was alreadt designed to handle
> exceptions which might work much better here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
