Qian Zhang created MESOS-9591:
---------------------------------

             Summary: Remove obsolete recovery code in Docker containerizer
                 Key: MESOS-9591
                 URL: https://issues.apache.org/jira/browse/MESOS-9591
             Project: Mesos
          Issue Type: Improvement
          Components: containerization
            Reporter: Qian Zhang


When fixing MESOS-8125, a [code 
logic|https://github.com/apache/mesos/blob/1.7.1/src/slave/containerizer/docker.cpp#L1028:L1063]
 was added in Docker containerizer to only reap the executor process if the 
executor can be connected via a TCP socket to avoid reaping an irrelevant 
process after the agent host is rebooted. However when fixing MESOS-9501 we 
have made agent not read the forked pid and libprocess pid after reboot, so I 
think the code logic added in Docker containerizer will never be hit and can be 
removed since after agent host reboot `run->forkedPid` and `run->libprocessPid` 
will always be `None()`, i.e., the container will be skipped 
[here|https://github.com/apache/mesos/blob/1.7.1/src/slave/containerizer/docker.cpp#L982:L984].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to