[ https://issues.apache.org/jira/browse/MESOS-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797034#comment-16797034 ]
Benjamin Bannier commented on MESOS-2842: ----------------------------------------- We observed the failure reported by [~tillt] in a 1.4.3-based test cluster. While 1.4.3 is EOL, the code doesn't seem to have changed a lot on {{master}}. What's the plan on fixing this check failure [~tillt]? Can we make a fix independent of whether we implement the feature this ticket is about? > Update FrameworkInfo.principal on framework re-registration > ----------------------------------------------------------- > > Key: MESOS-2842 > URL: https://issues.apache.org/jira/browse/MESOS-2842 > Project: Mesos > Issue Type: Bug > Reporter: Vinod Kone > Priority: Critical > Labels: foundations, security > > From the design doc: > This is a bit involved because ‘principal’ is used for authentication and > rate limiting. > The authentication part is straightforward because a framework with updated > ‘principal’ should authenticate with the new ‘principal’ before being allowed > to re-register. The ‘authenticated’ map already gets updated when the > framework disconnects and reconnects, so it is fine. > For rate limiting, Master:failoverFramework() needs to be changed to update > the principal in ‘frameworks.principals’ map and also remove the metrics for > the old principal if there are no other frameworks with this principal > (similar to what we do in Master::removeFramework()). > The Master::visit() and Master::_visit() should work with the current > semantics. > NOTE that the principal type used in Mesos has changed since this ticket was > originally filed; the master code should be checked thoroughly to ensure that > the above is still relevant! -- This message was sent by Atlassian JIRA (v7.6.3#76005)