[ 
https://issues.apache.org/jira/browse/MESOS-9672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801146#comment-16801146
 ] 

Vinod Kone commented on MESOS-9672:
-----------------------------------

I guess we would still need this incase the pid re-use happens even without an 
agent reboot (highly unlikely but technically possible).

> Docker containerizer should ignore pids of executors that do not pass the 
> connection check.
> -------------------------------------------------------------------------------------------
>
>                 Key: MESOS-9672
>                 URL: https://issues.apache.org/jira/browse/MESOS-9672
>             Project: Mesos
>          Issue Type: Bug
>          Components: containerization
>            Reporter: Meng Zhu
>            Priority: Major
>              Labels: containerization
>
> When recovering executors with a tracked pid we first try to establish a 
> connection to its libprocess address to avoid reaping an irrelevant process:
> https://github.com/apache/mesos/blob/4580834471fb3bc0b95e2b96e04a63d34faef724/src/slave/containerizer/docker.cpp#L1019-L1054
> If the connection fails to establish, we should not track its pid: 
> https://github.com/apache/mesos/blob/4580834471fb3bc0b95e2b96e04a63d34faef724/src/slave/containerizer/docker.cpp#L1071
> One trouble this might cause is that if the pid is being used by another 
> executor, this could lead to duplicate pid error and lead the agent into a 
> crash loop:
> https://github.com/apache/mesos/blob/4580834471fb3bc0b95e2b96e04a63d34faef724/src/slave/containerizer/docker.cpp#L1066-L1068



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to