[
https://issues.apache.org/jira/browse/MESOS-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804797#comment-16804797
]
Andrei Sekretenko edited comment on MESOS-2842 at 3/29/19 11:41 AM:
--------------------------------------------------------------------
The principal is being updated here:
[https://github.com/apache/mesos/blob/d24b3ad6496cafec8f8ea4b02aa106a30e5c1d75/src/master/master.cpp#L4996]
And there is a comment above which I do not like at all:
// Update the principal mapping for this framework, which is
// needed to keep the per-principal framework metrics accurate.
I'm wondering if there was a consensus about updating/not updating the
principal at the time when that code was written...
Edit - finally I got it: the purpose of that code is handling the UPID change,
not the principal update... and when the framework tries to change principal,
this code breaks everything.
was (Author: asekretenko):
The principal is being updated here:
[https://github.com/apache/mesos/blob/d24b3ad6496cafec8f8ea4b02aa106a30e5c1d75/src/master/master.cpp#L4996]
And there is a comment above which I do not like at all:
// Update the principal mapping for this framework, which is
// needed to keep the per-principal framework metrics accurate.
I'm wondering if there was a consensus about updating/not updating the
principal at the time when that code was written...
> Master crashes when framework changes principal on re-registration
> ------------------------------------------------------------------
>
> Key: MESOS-2842
> URL: https://issues.apache.org/jira/browse/MESOS-2842
> Project: Mesos
> Issue Type: Bug
> Reporter: Vinod Kone
> Assignee: Andrei Sekretenko
> Priority: Critical
> Labels: foundations, security
>
> The master should be updated to avoid crashing when a framework re-registers
> with a different principal.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
