[
https://issues.apache.org/jira/browse/MESOS-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804978#comment-16804978
]
Benno Evers commented on MESOS-9687:
------------------------------------
Interface extension landed in:
{noformat}
commit 8cba86825449c35733a0b4cf0d14284055c2cc30 (HEAD -> master, origin/master)
Author: Andrei Sekretenko <[email protected]>
Date: Fri Mar 29 14:23:57 2019 +0100
Extended the glog LogSink interface to be able to log microseconds.
Extended the LogSink interface to be able to log microseconds.
This makes possible to solve a problem with modules implementing custom
LogSink which currently log 000000 instead of microseconds.
This is a backport of this patch: https://github.com/google/glog/pull/441
to glog 0.3.3
Review: https://reviews.apache.org/r/70334/
{noformat}
Modules now can use the new interface method
{noformat}
virtual void send(LogSeverity severity, const char* full_filename,
const char* base_filename, int line,
const struct ::tm* tm_time,
const char* message, size_t message_len, int32 usecs)
{noformat}
to log including microseconds.
> Add the glog patch to pass microseconds via the LogSink interface.
> ------------------------------------------------------------------
>
> Key: MESOS-9687
> URL: https://issues.apache.org/jira/browse/MESOS-9687
> Project: Mesos
> Issue Type: Task
> Reporter: Andrei Sekretenko
> Priority: Major
>
> Currently, custom LogSink implementations in the modules (for example, this
> one:
> [https://github.com/dcos/dcos-mesos-modules/blob/master/logsink/logsink.hpp]
> )
> are logging `000000` instead of microseconds in the timestamp - simply
> because the LogSink interface in glog has no place for microseconds.
> The proposed glog fix is here: [https://github.com/google/glog/pull/441]
> Getting this into glog release might take a long time (they released 0.4.0
> recently, but the previous release 0.3.5 was two years ago), therefore it
> makes sense to add this patch into Mesos build.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
