[
https://issues.apache.org/jira/browse/MESOS-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809359#comment-16809359
]
Chun-Hung Hsiao commented on MESOS-9624:
----------------------------------------
Committed the following changes first:
{noformat}
commit 4fc6ceba906d4e726c6c9d1ebd94ece152f2cf57
Author: Chun-Hung Hsiao <[email protected]>
Date: Mon Apr 1 23:24:05 2019 -0700
Adjusted CSI v0 bundling and proto compilation.
This patch makes the following adjustments so we can build CSI v0 and v1
in the future:
* Standardize placements for third-party proto files: `csi.proto` from
CSI v0 should be in `csi/v0/` of the library root directory and that
from v1 should be in `csi/v1/` in the future. Dependent proto files
should import `csi/v0/csi.proto` or `csi/v1/csi.proto`.
* The generated files for CSI v0 is placed in `build/include/csi/v0`,
and those for CSI v1 will be in `build/include/csi/v1` in the future.
* Moved `include/csi/spec.hpp` to `include/mesos/csi/v0.hpp`. In the
future, CSI v1 proto headers will be in `include/mesos/csi/v1.hpp`.
* Install the CSI v0 proto file and its generated headers to
`$PREFIX/include/csi/v0` in autotools. CSI v1 files will be installed
at `$PREFIX/include/csi/v1` in the future.
Review: https://reviews.apache.org/r/70302/{noformat}
{noformat}
commit 35e57187b885afa87210c7d66e1dd43c08eded99
Author: Chun-Hung Hsiao <[email protected]>
Date: Mon Mar 25 18:16:21 2019 -0700
Moved CSI v0 type helpers to the `mesos/csi/v0.hpp` header.
The equality check and output helpers for CSI v0 protobufs are now
declared in the `v0.hpp` header to ensure ADL works properly. The
implementation is also moved to a new `v0.cpp` file.
The header and implementation files for CSI v0 utility helpers are also
renamed for future CSI v1 support.
Review: https://reviews.apache.org/r/70303{noformat}
> Bundle CSI spec v1.0 in Mesos.
> ------------------------------
>
> Key: MESOS-9624
> URL: https://issues.apache.org/jira/browse/MESOS-9624
> Project: Mesos
> Issue Type: Task
> Components: storage
> Reporter: Chun-Hung Hsiao
> Assignee: Chun-Hung Hsiao
> Priority: Critical
> Labels: mesosphere, storage
>
> We need to bundle both CSI v0 and v1 in Mesos. This requires some redesign of
> the source code filesystem layout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
