[
https://issues.apache.org/jira/browse/MESOS-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gavin updated MESOS-9606:
-------------------------
Comment: was deleted
(was: www.rtat.net)
> Reviewbot should only rebuild master if there are actually reviews to verify
> ----------------------------------------------------------------------------
>
> Key: MESOS-9606
> URL: https://issues.apache.org/jira/browse/MESOS-9606
> Project: Mesos
> Issue Type: Improvement
> Components: reviewbot
> Reporter: Benjamin Bannier
> Priority: Major
> Labels: integration
>
> Currently the Jenkins reviewbot setup first verifies that the {{master}}
> branch builds, and then invokes {{support/verify_reviews.py}} to validate
> reviews. This means that even if no reviews to build the job still takes
> roughly 40min just to verify the {{master}} branch.
> Instead the job should only validate {{master}} if there are actually reviews
> to validate. This could e.g., be accomplished by providing a "query flag" for
> {{support/verify_reviews.py}} which can return which reviews need validation
> and branching on that in the Jenkins shell script, or alternatively moving
> the building of {{master}} into {{support/verify_reviews.py}} (which might
> unlock other improvements like sharing a ccache between {{master}} build and
> builds of reviews).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
