[ https://issues.apache.org/jira/browse/MESOS-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831952#comment-16831952 ]
Chun-Hung Hsiao edited comment on MESOS-9762 at 5/2/19 8:48 PM: ---------------------------------------------------------------- Re 1: The "mesos-" prefix, if it eventually populates to the storage backend, can help the operator to distinguish Mesos-managed volumes. Imagine that I might be able to use some EBS plugin for SLRP, then when I go to the Amazon's EBS page, I can see which volumes are created by my Mesos cluster. We do a similar prefixing in Docker containerizer (and even parse the container IDs to recognize those w/ the prefix as Mesos-managed containers, which is bad :(). But this is not necessary. Re 2: From Mesos' perspective, the framework-specified ID is optional, and we can omit the dot if that's the case. If we remove the prefix and take your suggestion, we might get {{.<framework-specified-operation-id>}}, which looks okay. If we decide to keep the prefix, then I prefer putting the optional framework-specified ID at the end. Re 3: Yes. Re 4: Yes. was (Author: chhsia0): Re 1: The "mesos-" prefix can help if it eventually populates to the storage backend, to help the operator to distinguish Mesos-managed volumes. Imagine that I might be able to use some EBS plugin for SLRP, then when I go to the Amazon's EBS page, I can see which volumes are created by my Mesos cluster. We do a similar prefixing in Docker containerizer (and even parse the container IDs to recognize those w/ the prefix as Mesos-managed containers, which is bad :(). But this is not necessary. Re 2: From Mesos' perspective, the framework-specified ID is optional, and we can omit the dot if that's the case. If we remove the prefix and take your suggestion, we might get {{.<framework-specified-operation-id>}}, which looks okay. If we decide to keep the prefix, then I prefer putting the optional framework-specified ID at the end. Re 3: Yes. Re 4: Yes. > Encode framework-specified operation ID into CSI volume name. > ------------------------------------------------------------- > > Key: MESOS-9762 > URL: https://issues.apache.org/jira/browse/MESOS-9762 > Project: Mesos > Issue Type: Improvement > Components: storage > Reporter: Chun-Hung Hsiao > Priority: Major > > Currently, SLRP uses the internally-generated operation UUID as CSI volume > creation name, which brings extra difficulty for debugging because users have > to go through logs to figure out the operation UUID for a given > {{CREATE_DISK}} call. > Instead, we could encode the framework-specified operation ID into the volume > name. To ensure the uniqueness of each volume name, we can use the following > schema: > {noformat} > mesos-<base64-urlsafe-encode(operation-uuid)>.<framework-specified-operation-id>{noformat} > The prefix before the framework-specified operation ID would be 29 characters > long. > We can consider not having the {{mesos-}} prefix to even shorten it, but it > might not be a bad idea to have that prefix reserved for Mesos. -- This message was sent by Atlassian JIRA (v7.6.3#76005)