[ https://issues.apache.org/jira/browse/MESOS-9786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841469#comment-16841469 ]
Meng Zhu commented on MESOS-9786: --------------------------------- {noformat} commit d9ab461ad4dadf13ec45d52e83a0e9a2f452de74 (HEAD -> quota_race, apache/master) Author: Meng Zhu <m...@mesosphere.io> Date: Thu May 16 12:12:15 2019 +0200 Fix a bug where racing quota removal request could crash the master. Also added a test. Review: https://reviews.apache.org/r/70656 {noformat} > Race between two REMOVE_QUOTA calls crashes the master. > ------------------------------------------------------- > > Key: MESOS-9786 > URL: https://issues.apache.org/jira/browse/MESOS-9786 > Project: Mesos > Issue Type: Bug > Affects Versions: 1.6.2, 1.7.2, 1.8.0, 1.9.0 > Reporter: Andrei Sekretenko > Assignee: Meng Zhu > Priority: Major > Labels: resource-management > > The existence of the quota in the master is validated here: > [https://github.com/apache/mesos/blob/a9a2acabd03181865055b77cf81e7bb310b236d6/src/master/quota_handler.cpp#L700] > Then the quota is removed from master in a deferred method call: > [https://github.com/apache/mesos/blob/a9a2acabd03181865055b77cf81e7bb310b236d6/src/master/quota_handler.cpp#L744] > And then removed from allocator in another deferred call: > [https://github.com/apache/mesos/blob/a9a2acabd03181865055b77cf81e7bb310b236d6/src/master/quota_handler.cpp#L753] > So, there is a race between two simultaneous REMOVE_QUOTA calls. > We observe this race on a heavily loaded cluster. Currently we suspect that > the client retries the call (due to the call being not processed for a long > time), and this triggers the race. -- This message was sent by Atlassian JIRA (v7.6.3#76005)