[ 
https://issues.apache.org/jira/browse/MESOS-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872747#comment-16872747
 ] 

Meng Zhu commented on MESOS-9807:
---------------------------------

{noformat}
commit 8eba78cbddc8b70f78c07a501ee0dc1d6204f280
Author: Meng Zhu <m...@mesosphere.io>
Date:   Thu Jun 20 17:29:28 2019 -0700

    Replaced `Quota` with `Quota2` in the master state.

    This paves way to remove `struct Quota`.

    Review: https://reviews.apache.org/r/70916

commit 5907a357180ccd8fe398f2b6638c85912fafe8b2
Author: Meng Zhu <m...@mesosphere.io>
Date:   Thu Jun 20 18:50:38 2019 -0700

    Replaced the old `struct Quota`.

    The new `struct Quota` is consistent with the proto `QuotaConfig`
    where guarantees and limits are decoupled and uses more proper
    abstractions: `ResourceQuantities` and `ResourceLimits`.

    Review: https://reviews.apache.org/r/70919
{noformat}


> Introduce a `struct Quota` wrapper.
> -----------------------------------
>
>                 Key: MESOS-9807
>                 URL: https://issues.apache.org/jira/browse/MESOS-9807
>             Project: Mesos
>          Issue Type: Improvement
>          Components: allocation
>            Reporter: Meng Zhu
>            Assignee: Meng Zhu
>            Priority: Major
>              Labels: resource-management
>
> We should introduce:
> struct Qutota {
>   ResourceQuantities guarantees;
>   ResourceLimits limits;
> }
> There are a couple of small hurdles. First, there is already a struct Quota 
> wrapper in "include/mesos/quota/quota.hpp", we need to deprecate that first. 
> Second, `ResourceQuantities` and `ResourceLimits` are right now only used in 
> internal headers. We probably want to move them into public header, since 
> this struct will also be used in allocator interface which is also in the 
> public header. (Looking at this line, the boundary is alreayd breached: 
> https://github.com/apache/mesos/blob/master/include/mesos/allocator/allocator.hpp#L41)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to