[
https://issues.apache.org/jira/browse/MESOS-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874489#comment-16874489
]
Andrei Sekretenko commented on MESOS-9870:
------------------------------------------
There is one more problem which might be much more serious: removing a role
from framework's roles and framework's suppressed roles in the same call also
crashes the master.
Test via UPDATE_FRAMEWORK: [https://reviews.apache.org/r/70966/]
Re-subscribing also crashes (no wonder: they use the same code path) - I don't
have the test completed.
Patches with a fix:
[https://reviews.apache.org/r/70967/]
[https://reviews.apache.org/r/70968/]
> Adding a new role in a suppressed state crashes the master.
> -----------------------------------------------------------
>
> Key: MESOS-9870
> URL: https://issues.apache.org/jira/browse/MESOS-9870
> Project: Mesos
> Issue Type: Bug
> Reporter: Andrei Sekretenko
> Priority: Blocker
> Labels: resource-management
>
> Calling UPDATE_FRAMEWORK with a new role added both to 'FrameworkInfo.roles`
> and `suppressed_roles` crashes the master.
> The first place which doesn't expect this is increasing a `suppressed`
> allocator metric:
> [https://github.com/apache/mesos/blob/fe7be9701e92d863734621ae1a3d339bb8598044/src/master/allocator/mesos/hierarchical.cpp#L507]
> [
> https://github.com/apache/mesos/blob/fe7be9701e92d863734621ae1a3d339bb8598044/src/master/allocator/mesos/metrics.cpp#L255]
> Probably there are other similar places.
> Adding a new role in a suppressed state via re-subscribing should also
> trigger this bug - haven't checked it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
