[ 
https://issues.apache.org/jira/browse/MESOS-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900728#comment-16900728
 ] 

longfei edited comment on MESOS-9852 at 8/6/19 7:53 AM:
--------------------------------------------------------

Hi [~bmahler].

Actually I found this growth on a 1.7.2 master built 6 months ago. Then I tried 
the latest 1.7.x branch(whose configure.ac says it's 1.7.3). 

But I am not sure if this patch is included, I will build another one to see 
what will happen next.


was (Author: carlone):
Hi [~bmahler].

Actally I found this growth on a 1.7.2 master built 6 months ago. Then I tried 
the latest 1.7.x branch(whose configure.ac says it's 1.7.3). 

But I am not sure if this patch is included, I will build another one to see 
what will happen next.

> Slow memory growth in master due to deferred deletion of offer filters and 
> timers.
> ----------------------------------------------------------------------------------
>
>                 Key: MESOS-9852
>                 URL: https://issues.apache.org/jira/browse/MESOS-9852
>             Project: Mesos
>          Issue Type: Bug
>          Components: allocation, master
>            Reporter: Benjamin Mahler
>            Assignee: Benjamin Mahler
>            Priority: Critical
>              Labels: resource-management
>             Fix For: 1.5.4, 1.6.3, 1.7.3, 1.8.1, 1.9.0
>
>         Attachments: screenshot-1.png
>
>
> The allocator does not keep a handle to the offer filter timer, which means 
> it cannot remove the timer overhead (in this case memory) when removing the 
> offer filter earlier (e.g. due to revive):
> https://github.com/apache/mesos/blob/1.8.0/src/master/allocator/mesos/hierarchical.cpp#L1338-L1352
> In addition, the offer filter is allocated on the heap but not deleted until 
> the timer fires (which might take forever!):
> https://github.com/apache/mesos/blob/1.8.0/src/master/allocator/mesos/hierarchical.cpp#L1321
> https://github.com/apache/mesos/blob/1.8.0/src/master/allocator/mesos/hierarchical.cpp#L1408-L1413
> https://github.com/apache/mesos/blob/1.8.0/src/master/allocator/mesos/hierarchical.cpp#L2249
> We'll need to try to backport this to all active release branches.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to