[ 
https://issues.apache.org/jira/browse/MESOS-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911836#comment-16911836
 ] 

Greg Mann edited comment on MESOS-9545 at 8/21/19 1:25 AM:
-----------------------------------------------------------

1.8.x:
{noformat}
commit 13e4cd1c42ae88094f14d6b05cfb9832d4494193
Author: Greg Mann <g...@mesosphere.io>
Date:   Tue Apr 23 22:25:29 2019 -0700

    Transitioned tasks when an unreachable agent is marked as gone.

    This patch updates the master code responsible for marking
    agents as gone to properly transition tasks on agents which
    were previously marked as unreachable.

    Review: https://reviews.apache.org/r/70519/
{noformat}
{noformat}
commit 6f90cc334701fad10e721312cd4cbd0690e1c6ec
Author: Greg Mann <g...@mesosphere.io>
Date:   Tue Apr 23 22:25:21 2019 -0700

    Fixed a memory leak in the master's 'removeTask()' helper.

    Previously, all removed tasks were added to the
    `slaves.unreachableTasks` map. This patch adds a conditional
    so that removed tasks are only added to that structure when
    they are being marked unreachable.

    Review: https://reviews.apache.org/r/70518/
{noformat}

1.7.x:
{noformat}
commit 61f1155675bd3bc5312e0501ea6182d2ee7434af
Author: Greg Mann <g...@mesosphere.io>
Date:   Tue Apr 23 22:25:29 2019 -0700

    Transitioned tasks when an unreachable agent is marked as gone.

    This patch updates the master code responsible for marking
    agents as gone to properly transition tasks on agents which
    were previously marked as unreachable.

    Review: https://reviews.apache.org/r/70519/
{noformat}
{noformat}
commit 0c5e78bc26653d26a03b08b82923ea517de46fc0
Author: Greg Mann <g...@mesosphere.io>
Date:   Tue Apr 23 22:25:21 2019 -0700

    Fixed a memory leak in the master's 'removeTask()' helper.

    Previously, all removed tasks were added to the
    `slaves.unreachableTasks` map. This patch adds a conditional
    so that removed tasks are only added to that structure when
    they are being marked unreachable.

    Review: https://reviews.apache.org/r/70518/
{noformat}


was (Author: greggomann):
1.8.x:
{noformat}
commit 13e4cd1c42ae88094f14d6b05cfb9832d4494193
Author: Greg Mann <g...@mesosphere.io>
Date:   Tue Apr 23 22:25:29 2019 -0700

    Transitioned tasks when an unreachable agent is marked as gone.

    This patch updates the master code responsible for marking
    agents as gone to properly transition tasks on agents which
    were previously marked as unreachable.

    Review: https://reviews.apache.org/r/70519/
{noformat}
{noformat}
commit 6f90cc334701fad10e721312cd4cbd0690e1c6ec
Author: Greg Mann <g...@mesosphere.io>
Date:   Tue Apr 23 22:25:21 2019 -0700

    Fixed a memory leak in the master's 'removeTask()' helper.

    Previously, all removed tasks were added to the
    `slaves.unreachableTasks` map. This patch adds a conditional
    so that removed tasks are only added to that structure when
    they are being marked unreachable.

    Review: https://reviews.apache.org/r/70518/
{noformat}

> Marking an unreachable agent as gone should transition the tasks to terminal 
> state
> ----------------------------------------------------------------------------------
>
>                 Key: MESOS-9545
>                 URL: https://issues.apache.org/jira/browse/MESOS-9545
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Vinod Kone
>            Assignee: Greg Mann
>            Priority: Major
>              Labels: foundations
>             Fix For: 1.9.0
>
>
> If an unreachable agent is marked as gone, currently master just marks that 
> agent in the registry but doesn't do anything about its tasks. So the tasks 
> are in UNREACHABLE state in the master forever, until the master fails over. 
> This is not great UX. We should transition these to terminal state instead.
> This fix should also include a test to verify.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to