Benjamin Mahler commented on MESOS-9806:

commit b6c87d7c44346b2497ace65b1d2060ee423aa772
Author: Benjamin Mahler <bmah...@apache.org>
Date:   Wed Aug 21 20:10:42 2019 -0400

    Eliminated double lookups in the allocator.

    Review: https://reviews.apache.org/r/71345

commit 790c4e72e1460035b13bf27f2cb8999709e9767e
Author: Benjamin Mahler <bmah...@apache.org>
Date:   Wed Aug 21 20:11:31 2019 -0400

    Avoid duplicate allocatableTo call in the allocator.

    Review: https://reviews.apache.org/r/71346

> Address allocator performance regression due to the removal of quota role 
> sorter.
> ---------------------------------------------------------------------------------
>                 Key: MESOS-9806
>                 URL: https://issues.apache.org/jira/browse/MESOS-9806
>             Project: Mesos
>          Issue Type: Improvement
>          Components: allocation
>            Reporter: Meng Zhu
>            Assignee: Meng Zhu
>            Priority: Critical
>              Labels: resource-management
> In MESOS-9802, we removed the quota role sorter which is tech debt.
> However, this slows down the allocator. The problem is that in the first 
> stage, even though a cluster might have no active roles with non-default 
> quota, the allocator will now have to sort and go through each and every role 
> in the cluster. Benchmark result shows that for 1k roles with 2k frameworks, 
> the allocator could experience ~50% performance degradation.
> There are a couple of ways to address this issue. For example, we could make 
> the sorter aware of quota. And add a method, say `sortQuotaRoles`, to return 
> all the roles with non-default quota. Alternatively, an even better approach 
> would be to deprecate the sorter concept and just have two standalone 
> functions e.g. sortRoles() and sortQuotaRoles() that takes in the role tree 
> structure (not yet exist in the allocator) and return the sorted roles.

This message was sent by Atlassian Jira

Reply via email to