[
https://issues.apache.org/jira/browse/MESOS-9956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919445#comment-16919445
]
Benno Evers commented on MESOS-9956:
------------------------------------
{noformat}
commit 43b86da531a889b1c4b1d7ca6acb2eb924ea01e1 (origin/master, master)
Author: Chun-Hung Hsiao <chhs...@apache.org>
Date: Fri Aug 30 13:04:22 2019 +0200
Gracefully handled duplicated volumes from non-conforming CSI plugins.
If the SLRP uses a plugin that does not conform to the CSI spec and
reports duplicated volumes, the duplicate would be removed.
Review: https://reviews.apache.org/r/71414/
commit b18ce53fe8e49e6f030efe89e0976a9f72ad8b50 (1.9.x, origin/1.9.x)
Author: Chun-Hung Hsiao <chhs...@apache.org>
Date: Fri Aug 30 13:05:37 2019 +0200
Gracefully handled duplicated volumes from non-conforming CSI plugins.
If the SLRP uses a plugin that does not conform to the CSI spec and
reports duplicated volumes, the duplicate would be removed.
Review: https://reviews.apache.org/r/71414/
{noformat}
> CSI plugins reporting duplicated volumes will crash the agent.
> --------------------------------------------------------------
>
> Key: MESOS-9956
> URL: https://issues.apache.org/jira/browse/MESOS-9956
> Project: Mesos
> Issue Type: Bug
> Components: storage
> Reporter: Chun-Hung Hsiao
> Assignee: Chun-Hung Hsiao
> Priority: Blocker
> Labels: mesosphere, storage
>
> The CSI spec requires volumes to be uniquely identifiable by ID, and thus
> SLRP currently assumes that a {{ListVolumes}} call does not return duplicated
> volumes. However, if a SLRP uses a non-conforming CSI plugin that reports
> duplicated volumes, these volumes would corrupt the SLRP checkpoint and cause
> the agent to crash at the next reconciliation:
> {noformat}
> F0829 07:13:55.171332 12721 provider.cpp:1089] Check failed:
> !checkpointedMap.contains(resource.disk().source().id()){noformat}
> MESOS-9254 introduces periodic reconciliation which make this problem much
> easier to manifest.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
