[ 
https://issues.apache.org/jira/browse/MESOS-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964806#comment-16964806
 ] 

Benjamin Bannier commented on MESOS-9948:
-----------------------------------------

Backports by [~bmahler]:

* {{1.5.x}}
{noformat}
commit 2b3a1feb4c3be8aafdbabdb041ff7dc083dc884e
Author: Benjamin Mahler <bmah...@apache.org>
Date:   Fri Oct 4 13:53:52 2019 -0400    Fixed master::Slave::hasExecutor 
performance issue.
    
    This is a backport of the broader fix in MESOS-9948.{noformat}
* {{1.6.x}}
{noformat}
commit 86ce596a352ed7f6ebd87702c21d669d6c4be7af
Author: Benjamin Mahler <bmah...@apache.org>
Date:   Fri Oct 4 13:53:19 2019 -0400    Fixed master::Slave::hasExecutor 
performance issue.
    
    This is a backport of the broader fix in MESOS-9948. {noformat}
* {{1.7.x}}
{noformat}
commit 7e036afedcba87ee5365c399da884643a5e5497f
Author: Benjamin Mahler <bmah...@apache.org>
Date:   Fri Oct 4 13:52:20 2019 -0400    Fixed master::Slave::hasExecutor 
performance issue.
    
    This is a backport of the broader fix in MESOS-9948. {noformat}
* {{1.8.x}}
{noformat}
commit 9a849dd570c53e21ae8d952f8d581691ccbd7b1e
Author: Benjamin Mahler <bmah...@apache.org>
Date:   Fri Oct 4 13:51:34 2019 -0400    Fixed master::Slave::hasExecutor 
performance issue.
    
    This is a backport of the broader fix in MESOS-9948. {noformat}
* {{1.9.x}}
{noformat}
commit 2c1eb0cdc57e24983a55bfade9e0a8f9a24c0a0d
Author: Benjamin Mahler <bmah...@apache.org>
Date:   Fri Oct 4 13:50:38 2019 -0400    Fixed master::Slave::hasExecutor 
performance issue.
    
    This is a backport of the broader fix in MESOS-9948. {noformat}

> master::Slave::hasExecutor occupies 37% of a 150 second perf sample.
> --------------------------------------------------------------------
>
>                 Key: MESOS-9948
>                 URL: https://issues.apache.org/jira/browse/MESOS-9948
>             Project: Mesos
>          Issue Type: Improvement
>          Components: master
>            Reporter: Benjamin Mahler
>            Assignee: Benjamin Bannier
>            Priority: Major
>              Labels: foundations, performance
>             Fix For: 1.5.4, 1.6.3, 1.7.3, 1.8.2, 1.9.1, 1.10.0
>
>         Attachments: long-fei-enable-debug-slow-master.gz
>
>
> If you drop the attached perf stacks into flamescope, you can see that 
> mesos::internal::master::Slave::hasExecutor occupies 37% of the overall 
> samples!
> This function does 3 hashmap lookups, 1 can be eliminated for a quick win. 
> However, the larger improvement here will come from eliminating many of the 
> calls to this function.
> This was reported by [~carlone].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to