[
https://issues.apache.org/jira/browse/MESOS-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Mahler reassigned MESOS-10137:
---------------------------------------
Fix Version/s: 1.11.0
Assignee: Benjamin Mahler
Resolution: Fixed
Ah I misread this issue initially, to get it compiling again I committed
[~chris.d.holman]'s suggestion to disambiguate. It must depend on the compiler
version since there wasn't an ambiguity issue in our windows CI.
{noformat}
commit da08b0cc33d3b6b70a507348783a70ac863cb1dd
Author: Benjamin Mahler <bmah...@apache.org>
Date: Mon Jul 27 13:20:54 2020 -0400
Fixed a compilation issue on Windows with os::spawn.
Per MESOS-10137, the call to os::spawn touched here can be seen
as ambiguous by the compiler, given that windows adds a default
argument to os::spawn. Probably we need to remove the default
argument and explicitly implement os::spawn which calls into the
additional windows os::spawn with the extra environment argument.
{noformat}
> Mesos failed to build due to error C2668 on windows with MSVC
> -------------------------------------------------------------
>
> Key: MESOS-10137
> URL: https://issues.apache.org/jira/browse/MESOS-10137
> Project: Mesos
> Issue Type: Bug
> Components: build
> Affects Versions: master
> Reporter: LinGao
> Assignee: Benjamin Mahler
> Priority: Major
> Labels: windows
> Fix For: 1.11.0
>
> Attachments: build.log
>
>
> Hi All,
> I tried to build Mesos on Windows with VS2019. It failed to build due to
> error C2668: 'os::spawn': ambiguous call to overloaded function on Windows
> using MSVC. It can be reproduced on latest reversion d4634f4 on master
> branch. Could you please take a look at this isssue? Thanks a lot!
>
> Reproduce steps:
> 1. git clone -c core.autocrlf=true [https://github.com/apache/mesos]
> F:\gitP\apache\mesos
> 2. Open a VS 2019 x64 command prompt as admin and browse to
> F:\gitP\apache\mesos
> 3. mkdir build_amd64 && pushd build_amd64
> 4. cmake -G "Visual Studio 16 2019" -A x64
> -DCMAKE_SYSTEM_VERSION=10.0.18362.0 -DENABLE_LIBEVENT=1
> -DHAS_AUTHENTICATION=0 -DPATCHEXE_PATH="F:\tools\gnuwin32\bin" -T host=x64 ..
> 5. set _CL_=/D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING %_CL_%
> 6. msbuild /maxcpucount:4 /p:Platform=x64 /p:Configuration=Debug Mesos.sln
> /t:Rebuild
>
> ErrorMessage:
> F:\gitP\apache\mesos\3rdparty\stout\include\stout/os/windows/shell.hpp(168,68):
> error C2668: 'os::spawn': ambiguous call to overloaded function (compiling
> source file F:\gitP\apache\mesos\3rdparty\libprocess\src\authenticator.cpp)
> [F:\gitP\apache\mesos\build_amd64\3rdparty\libprocess\src\process.vcxproj]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
