[ 
https://issues.apache.org/jira/browse/METRON-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978592#comment-15978592
 ] 

ASF GitHub Bot commented on METRON-870:
---------------------------------------

Github user nishihatapalmer commented on the issue:

    https://github.com/apache/incubator-metron/pull/541
  
    Hi, byteseek author here.  I notice you're using the standard 
BoyerMooreHorspool searcher.  Just to let you know that the 
HorspoolFinalFlagSearcher offers much better performance than the standard 
Horspool searcher - about 1.5 to 2 times faster in my tests - and uses no more 
memory or pre-processing time.
    
    It's essentially the same algorithm as Horpsool, but re-arranges it a bit 
so that it only needs to verify a match when the algorithm detects that the 
last character matches the pattern, which can be done using a negative shift 
value (the "final flag").   Since verification is expensive to perform on each 
loop iteration, this performs much better in general.  


> Add filtering by packet payload to the pcap query
> -------------------------------------------------
>
>                 Key: METRON-870
>                 URL: https://issues.apache.org/jira/browse/METRON-870
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Casey Stella
>
> Currently we have the ability to filter packets in the pcap query tool by 
> header information (src/dest ip/port).  We should be able to filter by binary 
> regex on the packets themselves. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to