[ 
https://issues.apache.org/jira/browse/METRON-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018490#comment-16018490
 ] 

ASF GitHub Bot commented on METRON-958:
---------------------------------------

Github user merrimanr commented on the issue:

    https://github.com/apache/metron/pull/593
  
    +1 worked as advertised.  I tested this in full dev using a topic with an 
'_' character in the name.  A query within the time range returned results and 
a query outside of the time range returned a "No results returned" message and 
did not throw an exception.
    
    I did notice that when I set the query time range to a different day or 
month a map reduce job still ran.  Is this expected?  I would expect the query 
map reduce job to be smart enough to exclude files in this case.  That is 
outside the scope of this PR but wanted to bring it up.


> PCAP Query job throws exception when no files returned by time range query
> --------------------------------------------------------------------------
>
>                 Key: METRON-958
>                 URL: https://issues.apache.org/jira/browse/METRON-958
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Michael Miklavcic
>            Assignee: Michael Miklavcic
>
> {code}
> bin/pcap_query.sh query -df "yyyyMMddHHmm" -st 201705162000 --query ""
> Exception in thread "main" java.lang.IllegalArgumentException: Can not create 
> a Path from an empty string
>         at org.apache.hadoop.fs.Path.checkPathArg(Path.java:126)
>         at org.apache.hadoop.fs.Path.<init>(Path.java:134)
>         at 
> org.apache.hadoop.mapreduce.lib.input.FileInputFormat.addInputPaths(FileInputFormat.java:485)
>         at org.apache.metron.pcap.mr.PcapJob.createJob(PcapJob.java:285)
>         at org.apache.metron.pcap.mr.PcapJob.query(PcapJob.java:237)
>         at org.apache.metron.pcap.query.PcapCli.run(PcapCli.java:138)
>         at org.apache.metron.pcap.query.PcapCli.main(PcapCli.java:53)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:498)
>         at org.apache.hadoop.util.RunJar.run(RunJar.java:233)
>         at org.apache.hadoop.util.RunJar.main(RunJar.java:148)
> {code}
> For this particular data set, 201705161900 worked fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to