[
https://issues.apache.org/jira/browse/METRON-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044934#comment-16044934
]
ASF GitHub Bot commented on METRON-777:
---------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r121211536
--- Diff:
metron-extensions/metron-parser-extensions/metron-parser-bro-extension/metron-parser-bro/src/main/config/zookeeper/enrichments/bro.json
---
@@ -0,0 +1,17 @@
+{
+ "enrichment" : {
--- End diff --
I don't think I made my point clearly enough. I don't have a problem with
having the ability to add enrichments, indexing definitions, etc in an
extension.
My point is that the defaults we provide should make as few assumptions
about the environment as possible.
For example, when I install the Bro parser extension from this PR, it is
going to perform GeoIP and malicious IP lookups. That assumes that the
environment in which I am installing this has the Geo database setup correctly
and a malicious IP table setup in HBase.
Are those fair assumptions to make? It seems to me we should make as few
assumptions as possible so this can "just work" for the greatest number of
users out there. I would default to no enrichments, for example.
> Create a plugin system for Metron based on 'NAR'
> ------------------------------------------------
>
> Key: METRON-777
> URL: https://issues.apache.org/jira/browse/METRON-777
> Project: Metron
> Issue Type: New Feature
> Reporter: Otto Fowler
> Assignee: Otto Fowler
>
> The success of the Metron project will be greatly dependent on community
> participation, and with that the ability to adapt and extend Metron without
> having to maintain a fork of the project.
> As organizations and individuals look to extend the Metron system with custom
> parsers, enrichments, and stellar functions that may be proprietary in
> nature, the ability to develop and deploy these extensions outside the Metron
> code base is critically important.
> To that end, and after community discussion and proposal we create or
> formalize the 'plugin' development story in Metron.
> The proposal is to adapt the Apache Nifi NAR system for use in Metron. This
> will provide the system with:
> * archetype(s) for developer projects and independent development
> * defined packaging and metadata for 'plugin' products
> * loading and instantiation with classloader isolation capabilities
> * removing the necessity for shading plugin jars
> These capabilities will also enable other features, such as plugin lifecycle,
> plugin configuration+redeployment, and other things.
> The plugin archetypes and their installation will be a followon
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)