[
https://issues.apache.org/jira/browse/METRON-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054774#comment-16054774
]
ASF GitHub Bot commented on METRON-986:
---------------------------------------
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/608
What we have **should** work out-of-the-box for most NICs. Of course, I
have only been able to test on the x520 and Cisco VNICs, so that is all I can
really be sure of.
If changes would be needed, it would likely be in the initialization of the
`rte_eth_conf` and `rte_eth_txconf` structs. The defaults are currently
provided in `nic.c`.
I was going to make this configurable, but decided not to in this PR due to
the amount of work needed. I would have had to define configurable values that
populate all of the possible fields in each of these structs (which are quite
numerous). I would have had to allow configuration of these values via the
config file, rather than just the command-line, since they are so numerous.
There is also the challenge of how to allow a user to dynamically configure
values that are effectively macros, if that is even possible. For example, how
should a user define something like the following in a configuration file? I'd
have to dig for a good way to handle this.
```
static const struct rte_eth_conf rx_conf_default = {
.rxmode = {
.mq_mode = ETH_MQ_RX_RSS,
...
}
}
```
> Enhance Fastcapa to Support Intel X520
> --------------------------------------
>
> Key: METRON-986
> URL: https://issues.apache.org/jira/browse/METRON-986
> Project: Metron
> Issue Type: Improvement
> Reporter: Nick Allen
> Assignee: Nick Allen
>
> Enhance Fastcapa to improve interoperability with the Intel X520 NIC, address
> bugs uncovered during performance testing, and some basic enhancements to
> improve ease-of-use.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
