[ 
https://issues.apache.org/jira/browse/METRON-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061067#comment-16061067
 ] 

ASF GitHub Bot commented on METRON-1003:
----------------------------------------

Github user bjigmp closed the pull request at:

    https://github.com/apache/metron/pull/623


> ParserUtil parses dates incorrect
> ---------------------------------
>
>                 Key: METRON-1003
>                 URL: https://issues.apache.org/jira/browse/METRON-1003
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Vladimir
>            Priority: Minor
>
> ParserUtils class has method convertToEpoch that takes month, day and time 
> (as strings), parses it and returns milliseconds since epoch.
> Month expected in "MMM" format (i.e. "Jun")
> Month is parsed and then it is tried to get int value as:
> {code}
> String month = String.valueOf(cal.get(Calendar.MONTH));
> {code}
> But according to documentation (see 
> https://docs.oracle.com/javase/7/docs/api/java/util/Calendar.html#MONTH) 
> months start from 0.
> So this method returns incorrect value.
> This method should be refactored, but would be great to fix it and write some 
> tests before.
> This is minor bug as this method is used in FireEye parser only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to