[
https://issues.apache.org/jira/browse/METRON-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069645#comment-16069645
]
ASF GitHub Bot commented on METRON-1004:
----------------------------------------
GitHub user justinleet reopened a pull request:
https://github.com/apache/metron/pull/624
[DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maximum Time Limit
## Contributor Comments
This PR cleans up and speeds up various issues we've seen on Travis.
- This should avoid the skadoo, by just outright stopping problematic
threads.
- Allows for the reuse of some of the InMemoryComponents, to avoid a lot of
the spinup time in tests
- Improvements to a variety of tests to make them faster
- Refactoring of some parser integration tests to be less integrationy and
more unit test-ish. Specifically because not every parser needs a full
integration test and they take awhile.
- Moving to VM in Travis
- More details as provided in comments
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justinleet/metron METRON-1004
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/624.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #624
----
commit bd484b5a0bede9214ec39a3c6f4192d9e948ed35
Author: justinjleet <[email protected]>
Date: 2017-06-23T13:15:02Z
first pass. Still need to fix storm kafka interaction + possibly cleanup
commit a470063422314711ec99a298d646202deda32fba
Author: justinjleet <[email protected]>
Date: 2017-06-23T16:04:53Z
fixes plus logging
commit 05e0a6468d283a2ee6a0ce4be8c551373be7f75b
Author: justinjleet <[email protected]>
Date: 2017-06-23T19:01:27Z
more stuffs
commit 05b9c1f0d04a76afb97c90c33d82268618129806
Author: justinjleet <[email protected]>
Date: 2017-06-24T17:49:52Z
more fixes and update
commit 912575eb92b2baf6f1334991372a883ad252d866
Author: justinjleet <[email protected]>
Date: 2017-06-24T18:37:15Z
removing error code
commit 11473f63841e18cef2fbb046c70c2e052b498b4f
Author: justinjleet <[email protected]>
Date: 2017-06-24T18:47:58Z
maybe making it work for superclasses like the parser tests. Unsure if
it'll maven
commit fa5c05205e4d5bf17d5ea665fd98711085391403
Author: justinjleet <[email protected]>
Date: 2017-06-25T00:18:00Z
Removing approximately 1M log errors by actually cleaning up ZK
commit a5b152e0e300640364fc28a1ae1bc80d7be4f628
Author: justinjleet <[email protected]>
Date: 2017-06-25T02:04:44Z
empty
commit c9f072b5c8230e2b829dd15e167fa1297d8042bd
Author: justinjleet <[email protected]>
Date: 2017-06-26T13:22:15Z
Removing our artifacts before caching
commit d4ab212cd0867a3d35aa73381b8389063b6b22c1
Author: justinjleet <[email protected]>
Date: 2017-06-26T13:24:46Z
Trying to flush cache
commit f2979c2b1ca7a47a9a7fca161737cfc1fb14fbe6
Author: justinjleet <[email protected]>
Date: 2017-06-26T13:42:33Z
Undo flush
commit 97a679e9b53bc4351dc217d6138327996d0bf850
Author: justinjleet <[email protected]>
Date: 2017-06-23T13:21:27Z
Adding logging to try to figure out what's going on
commit aa837e07ee1660b53dbafed5e8bc1da1802c1dc7
Author: justinjleet <[email protected]>
Date: 2017-06-26T15:01:51Z
Adding time to integration test command
commit b1ede14c67178bed546e379baee9981bb165053f
Author: cstella <[email protected]>
Date: 2017-06-27T13:02:18Z
trimming tests down.
commit 6562246129ca3873a297a0746bcdafb613faf9ef
Author: justinjleet <[email protected]>
Date: 2017-06-27T15:27:51Z
Removing jacoco from Travis build
commit ad27176f957cdd87f0559c95d6a0eda42ba9f6d7
Author: justinjleet <[email protected]>
Date: 2017-06-27T19:33:42Z
Properly handle clearing out Metron artifacts from Maven so we don't cache
them
commit 6824ca9937a9e047d68f6eba6dc4e8ec42a0f870
Author: cstella <[email protected]>
Date: 2017-06-28T09:06:14Z
Move unit test to use mock htable rather than real hbase.
commit 8eeec0669b41925cf64085312e24027a8ab2dcdf
Author: cstella <[email protected]>
Date: 2017-06-28T09:22:40Z
Parallelizing the conditions to the STIX extractor test should speed things
up.
commit feab3ced086cc7bfb2b1ec99323d68e36001329d
Author: cstella <[email protected]>
Date: 2017-06-28T09:33:20Z
Config functions test should reuse the zookeeper instance.
commit fafa57df28572a9103fa8010ce3507cf917a6273
Author: cstella <[email protected]>
Date: 2017-06-28T09:40:59Z
FSFunctionsTest should reuse infrastructure rather than spinning up hdfs
and local clusters 17+ times
commit 1c98ae4d5d78d1da2d627e2a20d56e20fd1cbdf6
Author: cstella <[email protected]>
Date: 2017-06-28T10:01:14Z
Refactored HBaseClientTest to not delete tables, but rather just issue
deletes.
commit 9033f49f19e19079746993c9f0e7fe43886df1d2
Author: cstella <[email protected]>
Date: 2017-06-28T08:53:38Z
Setting global cache for npm and removing int tests for initial run.
commit a6f2e9f384558799d094c427a774af42241209c3
Author: cstella <[email protected]>
Date: 2017-06-28T09:58:08Z
Updating travis.
commit 46aacd7d4145c7cdbefb6949398722c79a1b82f3
Author: cstella <[email protected]>
Date: 2017-06-28T13:43:36Z
Updating travis to cache all forms of npm cache.
commit a8368fefe06c1c261a8c71f204efe82bcf836c72
Author: cstella <[email protected]>
Date: 2017-06-28T13:50:04Z
Updating.
commit e208bcad07c2b28c75fbfe5ccb81fec70fe81bc7
Author: cstella <[email protected]>
Date: 2017-06-28T13:55:24Z
updating travis again.
commit fdddd6d8740543695383705cb9dd6e05c1e7da10
Author: cstella <[email protected]>
Date: 2017-06-28T14:10:23Z
Updating travis.
commit de042bfeaa902b2d8ac92824db7a538689fb4d1f
Author: cstella <[email protected]>
Date: 2017-06-28T15:04:35Z
travis update
commit cb930fcfddab3e60d25422d967607482160adc65
Author: cstella <[email protected]>
Date: 2017-06-28T15:29:57Z
adding longer timeout for great success.
commit af9f186b06e27dd6f1e6641c2040416972b9a677
Author: cstella <[email protected]>
Date: 2017-06-28T15:43:19Z
removing quiet mode
----
> Travis CI - Job Exceeded Maximum Time Limit
> -------------------------------------------
>
> Key: METRON-1004
> URL: https://issues.apache.org/jira/browse/METRON-1004
> Project: Metron
> Issue Type: Bug
> Reporter: Nick Allen
> Fix For: Next + 1
>
>
> Most Travis CI jobs are failing with the following error message.
> bq. The job exceeded the maximum time limit for jobs, and has been terminated.
> Travis apparently has a hard 50 minute limit that will cause jobs to timeout.
>
> https://docs.travis-ci.com/user/customizing-the-build#Build-Timeouts
> There is some additional time for setting up the container that is counted in
> this hard 50 minute limit that is not reported in the UI. So even if a build
> says it took 44 minutes with a timeout, it likely in fact did hit the 50
> minute limit.
> Here are some examples of these failures.
> * https://travis-ci.org/apache/metron/builds/244574987
> * https://travis-ci.org/apache/metron/builds/244552768
> * https://travis-ci.org/apache/metron/builds/241249480
> This is a separate issue from the "Storm slots didn't shut down" issue that
> is tracked in a separate PR.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
