[ 
https://issues.apache.org/jira/browse/METRON-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074466#comment-16074466
 ] 

ASF GitHub Bot commented on METRON-1014:
----------------------------------------

GitHub user mattf-horton opened a pull request:

    https://github.com/apache/metron/pull/630

    METRON-1014 StellarShell class name typo

    ## Contributor Comments
    Fix a path typo
    
    To test is trivial, but unfortunately requires building and then launching 
quick-dev or other install, then invoke the stellar shell script.  If it 
launches successfully the bug is fixed.  It currently errors on a Class Not 
Found error.
    
    I've opened METRON-1015 to create an integration test for this issue 
(problem in the CLI independent of the Stellar executor).
    
    ## Pull Request Checklist
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [NA] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [NA] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [NA] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes: NA

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattf-horton/metron METRON-1014

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/630.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #630
    
----
commit a95c8ad69185e6265f81add6bf151229bf48fec5
Author: mattf-horton <[email protected]>
Date:   2017-07-05T09:09:52Z

    METRON-1014 StellarShell class name typo

----


> StellarShell class name typo
> ----------------------------
>
>                 Key: METRON-1014
>                 URL: https://issues.apache.org/jira/browse/METRON-1014
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Matt Foley
>
> [~ottobackwards] correctly observed: The stellar script 
> https://github.com/apache/metron/blob/master/metron-platform/metron-common/src/main/scripts/stellar
> is using the wrong main class  ( stellar.stellar.shell instead of 
> stellar.common.shell ).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to