[ https://issues.apache.org/jira/browse/METRON-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076554#comment-16076554 ]
ASF GitHub Bot commented on METRON-1018: ---------------------------------------- Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/635#discussion_r125910236 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchIndexingIntegrationTest.java --- @@ -102,11 +102,16 @@ public void setAdditionalProperties(Properties topologyProperties) { topologyProperties.setProperty("es.clustername", "metron"); topologyProperties.setProperty("es.port", "9300"); topologyProperties.setProperty("es.ip", "localhost"); - topologyProperties.setProperty("indexing.writer.class.name", "org.apache.metron.elasticsearch.writer.ElasticsearchWriter"); + topologyProperties.setProperty("indexing_writer_class_name", "org.apache.metron.elasticsearch.writer.ElasticsearchWriter"); } @Override public String cleanField(String field) { return field; } + --- End diff -- This was there previously and not something I added. It's an implementation of an abstract method in IndexingIntegrationTest and it looks like this implementation differs from the one in SolrIndexingIntegrationTest. I don't see a way to move this to a util class without significantly changing IndexingIntegrationTest. > Integration tests should reference flux yaml and property files deployed by > Ambari > ---------------------------------------------------------------------------------- > > Key: METRON-1018 > URL: https://issues.apache.org/jira/browse/METRON-1018 > Project: Metron > Issue Type: Bug > Reporter: Ryan Merriman > Assignee: Ryan Merriman > > This is a follow-up to METRON-990. During the review of that Jira it was > discovered that our integration tests are not referencing the actual flux > yaml and property files that are used in a Metron installation. This means > the integration tests must also be maintained separately with no automated > protection against regression in cases where flux yaml or property files > change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)