[
https://issues.apache.org/jira/browse/METRON-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080443#comment-16080443
]
ASF GitHub Bot commented on METRON-539:
---------------------------------------
GitHub user jjmeyer0 opened a pull request:
https://github.com/apache/metron/pull/641
METRON-539: added HASH function for stellar.
## Contributor Comments
Added a hash function to stellar. Many unit tests were created. Along with
these tests I opened the Stellar terminal and did the following:
### Start Stellar
```bash
mvn exec:java
-Dexec.mainClass="org.apache.metron.stellar.common.shell.StellarShell" -pl
metron-stellar/stellar-common/
```
### Test `HASH` Function
Below is the output of some of the tests I ran. To get all available inputs
for the second argument you can call `Security.getAlgorithms("MessageDigest")`
and print out the array. However, 'SHA-1', 'MD5', and 'SHA-256' are required by
all Java platforms. Please see
[MessageDigest](https://docs.oracle.com/javase/8/docs/api/java/security/MessageDigest.html)
and
[Security](https://docs.oracle.com/javase/8/docs/api/java/security/Security.html).
```bash
[Stellar]>>> Functions loaded, you may refer to functions now...
[Stellar]>>> some_string := 'my string to hash'
[Stellar]>>> HASH(some_string, 'md5')
E08863A4BE232F166C350F45C9DAA586
[Stellar]>>> some_serializable_object := [ 1, 2, 3 ]
[Stellar]>>> HASH(some_serializable_object, 'MD5')
2383CD011F1DA06A173ADE2F3F99CF62
[Stellar]>>>
```
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jjmeyer0/incubator-metron METRON-539
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/641.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #641
----
commit 8de6390825e3a17de226ace4764eb6a9d4cec609
Author: JJ <[email protected]>
Date: 2017-07-10T12:34:02Z
METRON-539: added HASH function for stellar.
----
> Add stellar keywords for hashing
> --------------------------------
>
> Key: METRON-539
> URL: https://issues.apache.org/jira/browse/METRON-539
> Project: Metron
> Issue Type: Improvement
> Reporter: Jon Zeolla
> Priority: Minor
>
> Stellar should have the ability to natively hash values using a prefix of TO
> or HASH, then the algorithm, and an optional length. For instance,
> "TO_SHA3_256" or "HASH_MD5."
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
