[ 
https://issues.apache.org/jira/browse/METRON-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082855#comment-16082855
 ] 

ASF GitHub Bot commented on METRON-1017:
----------------------------------------

Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/634#discussion_r126789624
  
    --- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml
 ---
    @@ -0,0 +1,174 @@
    +<?xml version="1.0"?>
    +<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
    +<!--
    +  Licensed to the Apache Software Foundation (ASF) under one
    +  or more contributor license agreements.  See the NOTICE file
    +  distributed with this work for additional information
    +  regarding copyright ownership.  The ASF licenses this file
    +  to you under the Apache License, Version 2.0 (the
    +  "License"); you may not use this file except in compliance
    +  with the License.  You may obtain a copy of the License at
    +
    +       http://www.apache.org/licenses/LICENSE-2.0
    +
    +  Unless required by applicable law or agreed to in writing, software
    +  distributed under the License is distributed on an "AS IS" BASIS,
    +  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +  See the License for the specific language governing permissions and
    +  limitations under the License.
    +-->
    +<configuration supports_final="true">
    +  <property>
    +    <name>geoip_url</name>
    +    
<value>http://geolite.maxmind.com/download/geoip/database/GeoLite2-City.mmdb.gz</value>
    +    <description>Location of the GeoIP data to load.</description>
    +    <display-name>GEOIP Load Datafile URL</display-name>
    +  </property>
    +  <property>
    +    <name>enrichment_host_known_hosts</name>
    +    <description>List of Known Hosts for Host Enrichment</description>
    +    <value>[{"ip":"10.1.128.236", "local":"YES", "type":"webserver", 
"asset_value" : "important"},{"ip":"10.1.128.237", "local":"UNKNOWN", 
"type":"unknown", "asset_value" : "important"},{"ip":"10.60.10.254", 
"local":"YES", "type":"printer", "asset_value" : "important"}]</value>
    +    <display-name>Host Enrichment</display-name>
    +    <value-attributes>
    +      <type>content</type>
    +    </value-attributes>
    +  </property>
    +  <property>
    +    <name>enrichment_kafka_start</name>
    +    <description>Enrichment Topology Spout Offset</description>
    +    <value>UNCOMMITTED_EARLIEST</value>
    +    <display-name>Enrichment Offset</display-name>
    --- End diff --
    
    I looked at this and the options are readable if you click the dropdown.  
Would be better if the whole value was displayed but I'm not even sure how to 
make the dropdown wider.  I can look into it.


> Ambari components should be separate
> ------------------------------------
>
>                 Key: METRON-1017
>                 URL: https://issues.apache.org/jira/browse/METRON-1017
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Ryan Merriman
>            Assignee: Ryan Merriman
>
> This is a follow-up to METRON-990.  During the review of that Jira it was 
> pointed out that a config change should only prompt a restart of the affected 
> component(s), not all components every time like it does now.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to