[
https://issues.apache.org/jira/browse/METRON-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083646#comment-16083646
]
ASF GitHub Bot commented on METRON-1022:
----------------------------------------
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/636
I just want to follow-up with something a bit more concrete suggestions. I
think the beginnings of an abstraction are there. You pulled out a bunch of
utility methods from `ElasticsearchWriter` which is good. I'm looking for a
DAO-like abstraction in `metron-elasticsearch` and the `ServiceImpl` in the
REST layer uses the generic DAO implementation (which would not live in the
REST layer so it's usable for lower level access) and the index impl is
specified by at runtime. The impl for the DAO would live in one of
`metron-elasticsearch` or `metron-solr`.
Again, these are my $0.02 and just suggestions.
> Elasticsearch REST endpoint
> ---------------------------
>
> Key: METRON-1022
> URL: https://issues.apache.org/jira/browse/METRON-1022
> Project: Metron
> Issue Type: New Feature
> Reporter: Ryan Merriman
>
> We need a "search" endpoint that will allow basic lucene-style searches with
> sorting and pagination options. This endpoint should have a light
> abstraction on top to make it simpler to consume and possibly allow different
> search engines to be used in the future.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
