[ 
https://issues.apache.org/jira/browse/METRON-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086051#comment-16086051
 ] 

ASF GitHub Bot commented on METRON-1037:
----------------------------------------

Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/metron/pull/651#discussion_r127279766
  
    --- Diff: 
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/MathFunctionsTest.java
 ---
    @@ -44,4 +44,16 @@ public void testAbs() {
         Assert.assertEquals((Double)run("ABS(value)", ImmutableMap.of("value", 
-10.5)), 10.5, 1e-7);
       }
     
    +  @Test
    +  public void testPower() {
    +    Assert.assertEquals((Double)run("POWER(e,b)", ImmutableMap.of("e", 
2.0, "b", 2.0)), 4.0, 1e-7 );
    --- End diff --
    
    Please put expected value first, test result value second, in 
assertEquals() calls.  Otherwise reported failures look funny.


> Stellar power function
> ----------------------
>
>                 Key: METRON-1037
>                 URL: https://issues.apache.org/jira/browse/METRON-1037
>             Project: Metron
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Simon Elliston Ball
>
> Stellar does not currently have a power function. We should have a function 
> of the form POWER(number,power) named for consistency with SQL and Excel. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to