[ 
https://issues.apache.org/jira/browse/METRON-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093433#comment-16093433
 ] 

ASF GitHub Bot commented on METRON-1053:
----------------------------------------

GitHub user nickwallen opened a pull request:

    https://github.com/apache/metron/pull/659

    METRON-1053 Relocate Metron Docker

    Having `metron-docker` at the top-level of the project seems to catch the 
attention of new users. Some then start using metron-docker to 
explore/try-out/demo Metron.  The `metron-docker` code that we have is not 
well-suited for this purpose. It is only really useful for development. It is 
not regularly tested and maintained like our Vagrant environment.
    
    ### Changes
    
    * Moved `metron-docker` to `metron-contrib/metron-docker`.  I based the 
top-level name on a popular suggestion from the mailing list along with 
matching the existing top-level naming convention (metron-*).
    
    * Fixed an issue with untar'ing the Kafka, HBase, and Hadoop tarballs.  It 
seems that the behavior of Docker's `ADD` now is to automatically untar.   That 
is at least in Docker for Mac version 17.06.0-ce-mac19.  I assume on older 
versions this was not the case,  I changed this logic to avoid using `ADD` so 
that it would work for older and newer versions of Docker.
    
    * Updated the documentation to make it clear that `metron-docker` is for 
development purposes only.
    
    ### Testing
    
    I launched `metron-docker` based on the instructions in the README.  The 
entire Docker compose application launched successfully and I validated that I 
was able to hit all of the web interfaces outlined in the README.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickwallen/metron METRON-1053

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #659
    
----
commit d34540ec7efd2504afe943116a1efafd06a11b44
Author: Nick Allen <[email protected]>
Date:   2017-07-19T17:06:15Z

    METRON-1053 Relocate Metron Docker

----


> Relocate Metron Docker
> ----------------------
>
>                 Key: METRON-1053
>                 URL: https://issues.apache.org/jira/browse/METRON-1053
>             Project: Metron
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Nick Allen
>            Priority: Minor
>             Fix For: 0.4.1
>
>
> Having metron-docker at the top-level of the project seems to catch the 
> attention of new users.  Some then start using metron-docker to 
> explore/try-out/demo Metron.  
> The metron-docker code that we have is not well-suited for this purpose.  It 
> is only really useful for development.  It is not regularly tested and 
> maintained like our Vagrant environment.
> I am proposing that we move the top-level "metron-docker" directory to 
> another location to avoid confusing new users.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to