[ https://issues.apache.org/jira/browse/METRON-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100489#comment-16100489 ]
ASF GitHub Bot commented on METRON-1038: ---------------------------------------- Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r129379794 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/math/StellarMathFunction.java --- @@ -0,0 +1,64 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ +package org.apache.metron.stellar.common.utils.math; + +import org.apache.metron.stellar.dsl.Context; +import org.apache.metron.stellar.dsl.ParseException; +import org.apache.metron.stellar.dsl.StellarFunction; + +import java.util.List; + +public class StellarMathFunction implements StellarFunction { + MathOperation _func; + public StellarMathFunction(MathOperations _func) { + this._func = _func.op; + } + + public StellarMathFunction(MathOperation _func) { + this._func = _func; + } + + @Override + public Object apply(List<Object> args, Context context) throws ParseException { + if(args.size() < _func.getMaxArgs()) { --- End diff -- If this is the logical use of getMaxArgs() then it should be called minRequiredArgs(), shouldn't it? Or perhaps you need another member for that. > Stellar should have a better collection of basic math operations > ---------------------------------------------------------------- > > Key: METRON-1038 > URL: https://issues.apache.org/jira/browse/METRON-1038 > Project: Metron > Issue Type: Improvement > Reporter: Casey Stella > > At the moment the math functions are woefully incomplete. > We should add at least the ones difficult or impossible to reconstruct using > existing stellar primitives/math functions: > * log10 > * log2 > * ln > * sqrt > * ceil > * floor > * sin > * cos > * tan -- This message was sent by Atlassian JIRA (v6.4.14#64029)