[
https://issues.apache.org/jira/browse/METRON-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102349#comment-16102349
]
ASF GitHub Bot commented on METRON-777:
---------------------------------------
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
@ottobackwards , I am strongly in favor of your decision to keep the
bundles-lib and bundles-maven-plugin at the top level. Since they are clones
of external functionality, they should be kept as independent of the rest of
Metron as possible, so as to ease future updates to track advances in the NiFi
implementation.
I recommend that you pick a _release version_ of NiFi NAR to clone. This
will (a) help give known quality, as releases are usually subjected to more
testing than individual commits; (b) ease tracking bugs and patches, since
formal releases are usually better documented as to what is and isn't in them,
and (c) allow comparison by tag instead of commit number.
* The latest released version of nifi-maven is
`rel/nifi-nar-maven-plugin-1.2.0` tag, at SHA1= d0c9d46 from 14 Mar 2017. This
is the same as current master, except for a version change in preparation for
the next development cycle. So I suggest you undo (reverse-apply) patch
fc124e5, to revert the version designation to the released version. If that's
still meaningful in your modified version, where I hope you've kept a record of
where it came from.
* The latest released version of nifi, and hence of the path
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/ , is
`rel/nifi-1.3.0` tag at SHA1=ddb7361 from 5 Jun 2017. That's both the overall
NiFi SHA1 commit, and the latest change on nifi-nar-utils subdirectory. This
is somewhat newer than your current reference SHA1 of d90cf84 on 24 Mar 2017.
There is a substantive change on 6 Apr, "NIFI-3520 Refactory instance class
loading" which includes sub-task "Refactoring nifi-nar-utils so that
ExtensionManager only lives in nifi-framework". So please consider updating to
the nifi-1.3.0 release version. If this is prohibitively difficult, let us
know.
> Create a plugin system for Metron based on 'NAR'
> ------------------------------------------------
>
> Key: METRON-777
> URL: https://issues.apache.org/jira/browse/METRON-777
> Project: Metron
> Issue Type: New Feature
> Reporter: Otto Fowler
> Assignee: Otto Fowler
>
> The success of the Metron project will be greatly dependent on community
> participation, and with that the ability to adapt and extend Metron without
> having to maintain a fork of the project.
> As organizations and individuals look to extend the Metron system with custom
> parsers, enrichments, and stellar functions that may be proprietary in
> nature, the ability to develop and deploy these extensions outside the Metron
> code base is critically important.
> To that end, and after community discussion and proposal we create or
> formalize the 'plugin' development story in Metron.
> The proposal is to adapt the Apache Nifi NAR system for use in Metron. This
> will provide the system with:
> * archetype(s) for developer projects and independent development
> * defined packaging and metadata for 'plugin' products
> * loading and instantiation with classloader isolation capabilities
> * removing the necessity for shading plugin jars
> These capabilities will also enable other features, such as plugin lifecycle,
> plugin configuration+redeployment, and other things.
> The plugin archetypes and their installation will be a followon
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
