[ 
https://issues.apache.org/jira/browse/METRON-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102590#comment-16102590
 ] 

ASF GitHub Bot commented on METRON-777:
---------------------------------------

Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/metron/pull/530#discussion_r129737358
  
    --- Diff: 
bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java
 ---
    @@ -0,0 +1,326 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron;
    +
    +import org.apache.maven.artifact.Artifact;
    +import org.apache.maven.artifact.handler.ArtifactHandler;
    +import org.apache.maven.artifact.handler.manager.ArtifactHandlerManager;
    +import org.apache.maven.artifact.repository.ArtifactRepository;
    +import org.apache.maven.plugin.AbstractMojo;
    +import org.apache.maven.plugin.MojoExecutionException;
    +import org.apache.maven.plugin.MojoFailureException;
    +import org.apache.maven.plugins.annotations.Component;
    +import org.apache.maven.plugins.annotations.LifecyclePhase;
    +import org.apache.maven.plugins.annotations.Mojo;
    +import org.apache.maven.plugins.annotations.Parameter;
    +import org.apache.maven.plugins.annotations.ResolutionScope;
    +import org.apache.maven.project.DefaultProjectBuildingRequest;
    +import org.apache.maven.project.MavenProject;
    +import org.apache.maven.project.ProjectBuilder;
    +import org.apache.maven.project.ProjectBuildingException;
    +import org.apache.maven.project.ProjectBuildingRequest;
    +import org.apache.maven.project.ProjectBuildingResult;
    +import org.apache.maven.shared.dependency.tree.DependencyNode;
    +import org.apache.maven.shared.dependency.tree.DependencyTreeBuilder;
    +import 
org.apache.maven.shared.dependency.tree.DependencyTreeBuilderException;
    +import 
org.apache.maven.shared.dependency.tree.traversal.DependencyNodeVisitor;
    +import org.eclipse.aether.RepositorySystemSession;
    +
    +import java.util.ArrayDeque;
    +import java.util.Deque;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +/**
    + * Generates the listing of dependencies that is provided by the Bundle 
dependency of the current Bundle. This is important as artifacts that bundle 
dependencies will
    + * not project those dependences using the traditional maven dependency 
plugin. This plugin will override that setting in order to print the 
dependencies being
    + * inherited at runtime.
    + */
    +@Mojo(name = "provided-bundle-dependencies", defaultPhase = 
LifecyclePhase.PACKAGE, threadSafe = false, requiresDependencyResolution = 
ResolutionScope.RUNTIME)
    +public class BundleProvidedDependenciesMojo extends AbstractMojo {
    +
    +    /**
    +     * The Maven project.
    +     */
    +    @Parameter(defaultValue = "${project}", readonly = true, required = 
true)
    +    private MavenProject project;
    +
    +    /**
    +     * The local artifact repository.
    +     */
    +    @Parameter(defaultValue = "${localRepository}", readonly = true)
    +    private ArtifactRepository localRepository;
    +
    +    /**
    +     * The {@link RepositorySystemSession} used for obtaining the local 
and remote artifact repositories.
    +     */
    +    @Parameter(defaultValue = "${repositorySystemSession}", readonly = 
true)
    +    private RepositorySystemSession repoSession;
    +
    +    /**
    +     * If specified, this parameter will cause the dependency tree to be 
written using the specified format. Currently supported format are: 
<code>tree</code>
    +     * or <code>pom</code>.
    +     */
    +    @Parameter(property = "mode", defaultValue = "tree")
    +    private String mode;
    +
    +    /**
    +     * The type we are using for dependencies, should be nar, but may
    +     * be changed in the configuration if the plugin is producing
    +     * other archive extensions, this is a 'shared' configuration
    +     * with the NarMojo
    +     */
    +    @Parameter(property = "type", required = false, defaultValue = 
"bundle")
    +    protected String type;
    --- End diff --
    
    As noted in BundleMojo, perhaps packageClassifier or packageExtension, 
rather than "type"?


> Create a plugin system for Metron based on 'NAR'
> ------------------------------------------------
>
>                 Key: METRON-777
>                 URL: https://issues.apache.org/jira/browse/METRON-777
>             Project: Metron
>          Issue Type: New Feature
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>
> The success of the Metron project will be greatly dependent on community 
> participation, and with that the ability to adapt and extend Metron without 
> having to maintain a fork of the project.
> As organizations and individuals look to extend the Metron system with custom 
> parsers, enrichments, and stellar functions that may be proprietary in 
> nature, the ability to develop and deploy these extensions outside the Metron 
> code base is critically important.
> To that end, and after community discussion and proposal we create or 
> formalize the 'plugin' development story in Metron.  
> The proposal is to adapt the Apache Nifi NAR system for use in Metron.  This 
> will provide the system with:
> * archetype(s) for developer projects and independent development
> * defined packaging and metadata for 'plugin' products
> * loading and instantiation with classloader isolation capabilities
> * removing the necessity for shading plugin jars
> These capabilities will also enable other features, such as plugin lifecycle, 
> plugin configuration+redeployment, and other things.
> The plugin archetypes and their installation will be a followon



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to